You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by johnmccabe <gi...@git.apache.org> on 2016/04/05 17:46:05 UTC
[GitHub] brooklyn-server pull request: pass brooklynConfig when making call...
GitHub user johnmccabe opened a pull request:
https://github.com/apache/brooklyn-server/pull/102
pass brooklynConfig when making call to getLocationSpec
was failing for byon locations where the host wasn't specified in the type, see associated tests - byon catalog locations as shown in `testByonLocationHostsInConfig` had been failing due to `extractConfig` in the `ByonLocationResolver` throwing an `IllegalArgumentException` due to no hosts being found.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnmccabe/brooklyn-server fix/BROOKLYN-246
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit 85564d0383e992f1da062aebe59b0010f56384ea
Author: John McCabe <jo...@johnmccabe.net>
Date: 2016-04-05T15:40:51Z
pass brooklynConfig when making call to getLocationSpec
- was failing for byon locations where the host wasn't specified in the type, see associated tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: pass brooklynConfig when making call...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: pass brooklynConfig when making call...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/brooklyn-server/pull/102#issuecomment-205903571
LGTM - very nice when it's a one-line fix plus tests! Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: pass brooklynConfig when making call...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on the pull request:
https://github.com/apache/brooklyn-server/pull/102#issuecomment-205865191
fyi @aledsage @rdowner @neykov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---