You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2025/07/08 06:16:07 UTC

Re: [PR] [SPARK-52706][SQL] Fix inconsistencies and refactor primitive types in parser [spark]

cloud-fan commented on code in PR #51335:
URL: https://github.com/apache/spark/pull/51335#discussion_r2191574153


##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1349,32 +1358,26 @@ type
     | FLOAT | REAL
     | DOUBLE
     | DATE
-    | TIME
-    | TIMESTAMP | TIMESTAMP_NTZ | TIMESTAMP_LTZ
-    | STRING collateClause?
-    | CHARACTER | CHAR
-    | VARCHAR
+    | TIMESTAMP_LTZ | TIMESTAMP_NTZ | TIMESTAMP (WITHOUT TIME ZONE)?
     | BINARY
-    | DECIMAL | DEC | NUMERIC
     | VOID
     | INTERVAL

Review Comment:
   shall we move this one into `nonTrivialPrimitiveType`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org