[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #6585: [INLONG-6584][Sort] Add read phase metric and table level metric for MySQL

[GitBox <gi...@apache.org>]

yunqingmoswu commented on code in PR #6585:
URL: https://github.com/apache/inlong/pull/6585#discussion_r1030403641


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -73,11 +76,48 @@ public final class Constants {
      * Node id used in inlong metric
      */
     public static final String NODE_ID = "nodeId";
+    /**
+     * Database Name used in inlong metric
+     */
+    public static final String DATABASE_NAME = "database";

Review Comment:
   These constants are not considered general concepts, it is recommended to consider a more general design？



##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java:
##########
@@ -57,6 +57,9 @@ public final class Constants {
     public static final String NUM_BYTES_IN_PER_SECOND = "numBytesInPerSecond";
 
     public static final String NUM_RECORDS_IN_PER_SECOND = "numRecordsInPerSecond";
+
+    public static final String READ_PHASE = "readPhase";

Review Comment:
   Please add some comment for it,simply looking at this variable does not know the specific meaning?



##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/MetricType.java:
##########
@@ -0,0 +1,34 @@
+/*
+ *   Licensed to the Apache Software Foundation (ASF) under one
+ *   or more contributor license agreements.  See the NOTICE file
+ *   distributed with this work for additional information
+ *   regarding copyright ownership.  The ASF licenses this file
+ *   to you under the Apache License, Version 2.0 (the
+ *   "License"); you may not use this file except in compliance
+ *   with the License.  You may obtain a copy of the License at
+ *
+ *       http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *   Unless required by applicable law or agreed to in writing, software
+ *   distributed under the License is distributed on an "AS IS" BASIS,
+ *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *   See the License for the specific language governing permissions and
+ *   limitations under the License.
+ */
+
+package org.apache.inlong.sort.base;
+
+/**
+ * connector metric type enum
+ */
+public enum MetricType {

Review Comment:
   It seems unnecessary to define the metric type, just extend it on the option 'inlong.metric.label'.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org