You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/04 16:24:31 UTC
[GitHub] [spark] MaxGekk commented on issue #20793: [WIP][SPARK-23643]
Shrinking the buffer in hashSeed up to size of the seed parameter
MaxGekk commented on issue #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#issuecomment-469316130
@srowen I could fix those ML test by just replacing hard-coded numbers and bump `eps` up to 100 times (this is actually required for `LogisticRegressionSuite`) but I do believe it is better to make the test insensible to the seed so much. I could open a few sub-tasks for `SPARK-23643` . Maybe somebody from community could help to improve the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org