You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/28 13:41:37 UTC
[GitHub] [rocketmq] medusar opened a new pull request #2326: [ISSUE# 2325] Bugfix: use CopyOnWriteArrayList to avoid possible thread safety issues.
medusar opened a new pull request #2326:
URL: https://github.com/apache/rocketmq/pull/2326
## What is the purpose of the change
Use `CopyOnWriteArrayList` to avoid thread safety issues.
## Brief changelog
replace `Lists.newArrayList()` with `new CopyOnWriteArrayList<>()`
## Verifying this change
done
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] medusar commented on pull request #2326: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
medusar commented on pull request #2326:
URL: https://github.com/apache/rocketmq/pull/2326#issuecomment-704678804
@RongtongJin I have created a new [PR](https://github.com/apache/rocketmq/pull/2336) here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2326: [ISSUE# 2325] Bugfix: use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2326:
URL: https://github.com/apache/rocketmq/pull/2326#issuecomment-700029030
[](https://coveralls.io/builds/33770634)
Coverage decreased (-0.01%) to 51.287% when pulling **a19eb6000534c8a3817e88582d2e7b1630d2da3b on medusar:master** into **9f95a972e10e0681bc3f2d00e9957aa212e897b5 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #2326: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #2326:
URL: https://github.com/apache/rocketmq/pull/2326#issuecomment-701715204
@medusar Sorry, I want to help you resolve code conflict when merging to the develop branch, but it can't pass CI now because I forgot to delete a useless import. Could you resubmit a new PR to develop branch? I will continue to help you track the new PR. I will close this pr firstly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed pull request #2326: [ISSUE# 2325] Use CopyOnWriteArrayList to avoid possible thread safety issues.
Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #2326:
URL: https://github.com/apache/rocketmq/pull/2326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org