You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/05/18 11:14:09 UTC
[jira] [Commented] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278656#comment-13278656 ]
Martin Grigorov commented on WICKET-4555:
-----------------------------------------
Let's initialize the pagingNavigator in #onInitialize() instead of the first call of #onBeforeRender().
This way the getter will be still useful in most of the cases.
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira