You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/22 14:02:12 UTC

[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on a change in pull request #51: Add throughput field for ServiceMeshMetric

wu-sheng commented on a change in pull request #51:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/51#discussion_r618430486



##########
File path: service-mesh-probe/service-mesh.proto
##########
@@ -56,6 +56,9 @@ message ServiceMeshMetric {
     // The sidecar/proxy internal error code, the value bases on the implementation.
     // The envoy internal error codes are listed here, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
     string internalErrorCode = 14;
+
+    // The throughput detail of the mesh metrics.
+    Throughput throughput = 15;

Review comment:
       What is the relationship between TCP and HTTP about the traffic? Does TCP have latency?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org