You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/27 11:14:42 UTC

[GitHub] [airflow] ShaharPotash1 opened a new pull request #19249: Cast ds macro functions

ShaharPotash1 opened a new pull request #19249:
URL: https://github.com/apache/airflow/pull/19249


   
   As already written in this issue https://github.com/apache/airflow/issues/19241 strptime function required string, but got proxy if the variables ds/next_ds (the types of these variables changed on version 2.2.0) sent.
   This change will make the function `ds_add` and `ds_format` backward compatible.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #19249: Cast to string in ds macro functions

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #19249:
URL: https://github.com/apache/airflow/pull/19249#issuecomment-978420848


   Being finished in #19592 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #19249: Cast to string in ds macro functions

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #19249:
URL: https://github.com/apache/airflow/pull/19249#issuecomment-952921236


   Can you add tests for this? This should be done by adding a new file at `tests/macros/test_macros.py` with two test functions, one each for calling `ds_add` and `ds_format` with a lazy object proxy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #19249: Cast to string in ds macro functions

Posted by GitBox <gi...@apache.org>.

potiuk commented on pull request #19249:
URL: https://github.com/apache/airflow/pull/19249#issuecomment-963500346


   @ShaharPotash1  - any chance to add the tests?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #19249: Cast to string in ds macro functions

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #19249:
URL: https://github.com/apache/airflow/pull/19249#issuecomment-968872987


   I’m finishing the PR in #19592.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #19249: Cast to string in ds macro functions

Posted by GitBox <gi...@apache.org>.

potiuk closed pull request #19249:
URL: https://github.com/apache/airflow/pull/19249


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org