[GitHub] [tvm] jinhongyii commented on a diff in pull request #15742: [Unity][Disco] separate computation and communication into 2 stream

["jinhongyii (via GitHub)" <gi...@apache.org>]

jinhongyii commented on code in PR #15742:
URL: https://github.com/apache/tvm/pull/15742#discussion_r1326594671


##########
src/runtime/disco/nccl/nccl.cc:
##########
@@ -91,26 +90,34 @@ void AllReduce(NDArray send, ReduceKind reduce_kind, NDArray recv) {
   NCCLThreadLocalContext* ctx = NCCLThreadLocalContext::Get();
   ShapeTuple shape = send.Shape();
   int64_t numel = shape->Product();
+  Device device = ctx->worker->default_device;
+  DeviceAPI::Get(device)->SyncStreamFromTo(device, nullptr, ctx->stream);

Review Comment:
   makes sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org