You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/12 03:36:58 UTC
[jira] [Commented] (STREAMS-468) Fix failing IT in
streams-persist-elasticsearch
[ https://issues.apache.org/jira/browse/STREAMS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15740866#comment-15740866 ]
ASF GitHub Bot commented on STREAMS-468:
----------------------------------------
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/337
STREAMS-468: Fix failing IT in streams-persist-elasticsearch
As best I can tell, the test began failing under testNG because it tries to open too many clients.
The intent was to support multiple clients while letting components and testing share those clients.
After refactoring to use a map<config,client> pattern with a singleton accessor, all tests began passing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-468
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/337.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #337
----
commit 553662b7ed61309b3074dd28f3b2f9171774450f
Author: Steve Blackmon <sb...@apache.org>
Date: 2016-12-12T03:31:33Z
STREAMS-468: Fix failing IT in streams-persist-elasticsearch
As best I can tell, the test began failing under testNG because it tries to open too many clients.
The intent was to support multiple clients while letting components and testing share those clients.
After refactoring to use a map<config,client> pattern with a singleton accessor, all tests began passing.
----
> Fix failing IT in streams-persist-elasticsearch
> -----------------------------------------------
>
> Key: STREAMS-468
> URL: https://issues.apache.org/jira/browse/STREAMS-468
> Project: Streams
> Issue Type: Bug
> Reporter: Steve Blackmon
> Assignee: Steve Blackmon
>
> https://builds.apache.org/job/streams-project-verify/org.apache.streams$streams-persist-elasticsearch/56/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)