You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/11/09 06:57:52 UTC

[GitHub] [apisix-helm-chart] tzssangglass commented on a diff in pull request #390: feat: support for using apisix 3.x image

tzssangglass commented on code in PR #390:
URL: https://github.com/apache/apisix-helm-chart/pull/390#discussion_r1017498870


##########
charts/apisix/templates/configmap.yaml:
##########
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-{{- $isBeta := (semverCompare ">=2.99.0" .Values.apisix.image.tag) }}
+{{- $isBeta := (semverCompare ">=2.99.0-debian" .Values.apisix.image.tag) }}

Review Comment:
   `>=2.99.0-debian` is a bad syntax, I will try to update it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org