You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 11:51:42 UTC

[GitHub] [spark] linhongliu-db opened a new pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

linhongliu-db opened a new pull request #30354:
URL: https://github.com/apache/spark/pull/30354


   ### What changes were proposed in this pull request?
   In #30097, many rules changed from case class to object, but if the rule
   is stateful, there will be a problem. For example, if an object rule uses a
   `val` to refer to a config, it will be unchanged after initialization even if
   other spark session uses a different config value.
   
   ### Why are the changes needed?
   Avoid potential bug
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Existing UT
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726327591


   **[Test build #131007 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131007/testReport)** for PR 30354 at commit [`0fbbbdd`](https://github.com/apache/spark/commit/0fbbbdd889bb3e1223427099add1ef1a74e68382).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726218437


   **[Test build #130992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130992/testReport)** for PR 30354 at commit [`017ada5`](https://github.com/apache/spark/commit/017ada5e75769a6d4e905aafbe8321d57ab1c10e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726108294


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35605/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726092573


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35604/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726052354


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35598/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726328863






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726066133


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726045389


   **[Test build #130999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130999/testReport)** for PR 30354 at commit [`0d73f6a`](https://github.com/apache/spark/commit/0d73f6a1b9b4bc459d5cc808b9c7cb09ff124878).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726170453


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35613/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726066106


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35598/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726219881






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726108316






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726153654


   **[Test build #131007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131007/testReport)** for PR 30354 at commit [`0fbbbdd`](https://github.com/apache/spark/commit/0fbbbdd889bb3e1223427099add1ef1a74e68382).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726042021


   **[Test build #130998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130998/testReport)** for PR 30354 at commit [`5e6a3c0`](https://github.com/apache/spark/commit/5e6a3c0d0bb4000535fd998006b41a322cbf4621).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726188707






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726219881






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726105806


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35604/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] leanken removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
leanken removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726033664


   ```
   abstract class Rule[TreeType <: TreeNode[_]] extends Logging {
   
     /** Name for this rule, automatically inferred based on class name. */
     val ruleName: String = {
       val className = getClass.getName
       if (className endsWith "$") className.dropRight(1) else className
     }
   
     def apply(plan: TreeType): TreeType
   
     def conf: SQLConf = SQLConf.get
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] leanken commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
leanken commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726033664


   ```
   abstract class Rule[TreeType <: TreeNode[_]] extends Logging {
   
     /** Name for this rule, automatically inferred based on class name. */
     val ruleName: String = {
       val className = getClass.getName
       if (className endsWith "$") className.dropRight(1) else className
     }
   
     def apply(plan: TreeType): TreeType
   
     def conf: SQLConf = SQLConf.get
   }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726031435


   **[Test build #130992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130992/testReport)** for PR 30354 at commit [`017ada5`](https://github.com/apache/spark/commit/017ada5e75769a6d4e905aafbe8321d57ab1c10e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726066146


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35598/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726260340






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726188707






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726244875






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726244875






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726258675


   **[Test build #130999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130999/testReport)** for PR 30354 at commit [`0d73f6a`](https://github.com/apache/spark/commit/0d73f6a1b9b4bc459d5cc808b9c7cb09ff124878).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726243106


   **[Test build #130998 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130998/testReport)** for PR 30354 at commit [`5e6a3c0`](https://github.com/apache/spark/commit/5e6a3c0d0bb4000535fd998006b41a322cbf4621).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726105829






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726042021


   **[Test build #130998 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130998/testReport)** for PR 30354 at commit [`5e6a3c0`](https://github.com/apache/spark/commit/5e6a3c0d0bb4000535fd998006b41a322cbf4621).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30354:
URL: https://github.com/apache/spark/pull/30354#discussion_r522055220



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -51,9 +51,9 @@ object ResolveHints {
    * This rule must happen before common table expressions.
    */
   object ResolveJoinStrategyHints extends Rule[LogicalPlan] {
-    private val STRATEGY_HINT_NAMES = JoinStrategyHint.strategies.flatMap(_.hintAliases)
+    private def STRATEGY_HINT_NAMES = JoinStrategyHint.strategies.flatMap(_.hintAliases)

Review comment:
       will this change with config?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30354:
URL: https://github.com/apache/spark/pull/30354


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726328863






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726175701


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726066133






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726089608


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35605/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726153654


   **[Test build #131007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131007/testReport)** for PR 30354 at commit [`0fbbbdd`](https://github.com/apache/spark/commit/0fbbbdd889bb3e1223427099add1ef1a74e68382).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726105829






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726260340






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726031435


   **[Test build #130992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130992/testReport)** for PR 30354 at commit [`017ada5`](https://github.com/apache/spark/commit/017ada5e75769a6d4e905aafbe8321d57ab1c10e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726045389


   **[Test build #130999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130999/testReport)** for PR 30354 at commit [`0d73f6a`](https://github.com/apache/spark/commit/0d73f6a1b9b4bc459d5cc808b9c7cb09ff124878).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726188676


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35613/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] leanken commented on pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

Posted by GitBox <gi...@apache.org>.
leanken commented on pull request #30354:
URL: https://github.com/apache/spark/pull/30354#issuecomment-726034942


   Nice catch!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org