You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by jo...@apache.org on 2008/02/01 19:16:12 UTC
svn commit: r617585 - in
/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets:
GadgetSpecParser.java http/GadgetRenderingServlet.java
Author: johnh
Date: Fri Feb 1 10:16:11 2008
New Revision: 617585
URL: http://svn.apache.org/viewvc?rev=617585&view=rev
Log:
Changing string == "" to string.length() == 0.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecParser.java
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecParser.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecParser.java?rev=617585&r1=617584&r2=617585&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecParser.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetSpecParser.java Fri Feb 1 10:16:11 2008
@@ -550,7 +550,7 @@
public String getContentData(String view) {
Check.is(contentType == ContentType.HTML,
"getContentData() requires contentType HTML");
- if (view == null || view == "") {
+ if (view == null || view.length() == 0) {
view = DEFAULT_VIEW;
}
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java?rev=617585&r1=617584&r2=617585&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingServlet.java Fri Feb 1 10:16:11 2008
@@ -152,7 +152,7 @@
Gadget gadget = null;
String view = req.getParameter("view");
- view = (view == null || view == "") ? GadgetSpec.DEFAULT_VIEW : view;
+ view = (view == null || view.length() == 0) ? GadgetSpec.DEFAULT_VIEW : view;
try {
gadget = gadgetServer.processGadget(gadgetId,
getPrefsFromRequest(req),