You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2022/01/06 14:58:02 UTC
[GitHub] [jmeter] SampathKumarAmex opened a new pull request #690: Split function test refactor with failure and different success scena…
SampathKumarAmex opened a new pull request #690:
URL: https://github.com/apache/jmeter/pull/690
## Description
Split function unit test refactor with failure and different success scenarios.
## Motivation and Context
1. I have separated the test scenarios into three.
- Failure scenario
- Success scenario without passing any parameters
- Success scenario with previous result value only
Actually, it's good to further separate all the different variations in scenario #2. So that we will have feedback from all the tests in single execution (i.e. CI build) even when one of the test scenarios fail. Also, it improves the readability and help to understand the scenarios better. Having said that, I haven't done that as part of this PR.
2. Used the JUnit 5 assertions as the test is already using JUnit 5 `@Test` annotation. This is to make the JUnit 5 usage consistent in this test class
## How Has This Been Tested?
n/a - Unit test refactoring
## Screenshots (if appropriate):
## Types of changes
<!--- What types of changes does your code introduce? Delete as appropriate -->
- Bug fix (non-breaking change which fixes an issue)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [X] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] FSchumacher commented on pull request #690: Split function test refactor with failure and different success scena…
Posted by GitBox <gi...@apache.org>.
FSchumacher commented on pull request #690:
URL: https://github.com/apache/jmeter/pull/690#issuecomment-1008003015
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-commenter commented on pull request #690: Split function test refactor with failure and different success scena…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #690:
URL: https://github.com/apache/jmeter/pull/690#issuecomment-1006904543
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#690](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f0f2d5) into [master](https://codecov.io/gh/apache/jmeter/commit/37be72fc48121c142c0a4be1c634373e0f929882?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37be72f) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #690 +/- ##
=========================================
Coverage 55.59% 55.59%
- Complexity 10335 10336 +1
=========================================
Files 1059 1059
Lines 65045 65045
Branches 7399 7399
=========================================
+ Hits 36159 36161 +2
+ Misses 26337 26336 -1
+ Partials 2549 2548 -1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/jmeter/timers/PoissonRandomTimer.java](https://codecov.io/gh/apache/jmeter/pull/690/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbXBvbmVudHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci90aW1lcnMvUG9pc3NvblJhbmRvbVRpbWVyLmphdmE=) | `78.37% <0.00%> (+5.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37be72f...1f0f2d5](https://codecov.io/gh/apache/jmeter/pull/690?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] asfgit closed pull request #690: Split function test refactor with failure and different success scena…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #690:
URL: https://github.com/apache/jmeter/pull/690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org