You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2016/04/12 23:18:36 UTC
[02/50] incubator-impala git commit: IMPALA-2973: Loosen bound on
join timer test
IMPALA-2973: Loosen bound on join timer test
Code coverage builds are slower than release or debug builds. This
patch gives test_hash_join_timer extra time so this test doesn't cause
code coverage builds don't fail in Jenkins.
Change-Id: I5598e073d779f744d79c5292e80a8ed8f6aa9548
Reviewed-on: http://gerrit.cloudera.org:8080/2608
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Internal Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/c0397911
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/c0397911
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/c0397911
Branch: refs/heads/master
Commit: c0397911b5aec4733b284c9c76fc554db64ffbef
Parents: a75d7dd
Author: Jim Apple <jb...@cloudera.com>
Authored: Wed Mar 23 10:25:25 2016 -0700
Committer: Internal Jenkins <cl...@gerrit.cloudera.org>
Committed: Wed Mar 23 22:25:13 2016 +0000
----------------------------------------------------------------------
tests/query_test/test_hash_join_timer.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/c0397911/tests/query_test/test_hash_join_timer.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_hash_join_timer.py b/tests/query_test/test_hash_join_timer.py
index abbcab5..1979759 100644
--- a/tests/query_test/test_hash_join_timer.py
+++ b/tests/query_test/test_hash_join_timer.py
@@ -44,7 +44,9 @@ class TestHashJoinTimer(ImpalaTestSuite):
" where a.id>b.id and a.id=99",
"NESTED LOOP JOIN"]
]
- HASH_JOIN_UPPER_BOUND_MS = 1000
+ # IMPALA-2973: For non-code-coverage builds, 1000 milliseconds are sufficent, but more
+ # time is needed in code-coverage builds.
+ HASH_JOIN_UPPER_BOUND_MS = 2000
# IMPALA-2973: Temporary workaround: when timers are using Linux COARSE clockid_t, very
# short times may be measured as zero.
HASH_JOIN_LOWER_BOUND_MS = 0