You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by il...@apache.org on 2019/06/04 08:19:29 UTC

[dubbo-samples] branch master updated: polish the code

This is an automated email from the ASF dual-hosted git repository.

iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d3f68a  polish the code
6d3f68a is described below

commit 6d3f68aeae8ee4151c73a0a1244eab6798b37c1d
Author: Ian Luo <ia...@gmail.com>
AuthorDate: Tue Jun 4 16:19:12 2019 +0800

    polish the code
---
 dubbo-samples-api/pom.xml | 28 ++++++++++++++++++----------
 1 file changed, 18 insertions(+), 10 deletions(-)

diff --git a/dubbo-samples-api/pom.xml b/dubbo-samples-api/pom.xml
index 442e55b..be32f04 100644
--- a/dubbo-samples-api/pom.xml
+++ b/dubbo-samples-api/pom.xml
@@ -30,6 +30,14 @@
         <source.level>1.8</source.level>
         <target.level>1.8</target.level>
         <dubbo.version>2.7.2-SNAPSHOT</dubbo.version>
+        <junit.version>4.12</junit.version>
+        <docker-maven-plugin.version>0.30.0</docker-maven-plugin.version>
+        <jib-maven-plugin.version>1.2.0</jib-maven-plugin.version>
+        <maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
+        <maven-failsafe-plugin.version>3.0.0-M3</maven-failsafe-plugin.version>
+        <image.name>dubbo-samples-api</image.name>
+        <dubbo.port>20880</dubbo.port>
+        <man-class>org.apache.dubbo.samples.provider.Application</man-class>
     </properties>
 
     <dependencies>
@@ -42,7 +50,7 @@
         <dependency>
             <groupId>junit</groupId>
             <artifactId>junit</artifactId>
-            <version>4.12</version>
+            <version>${junit.version}</version>
             <scope>test</scope>
         </dependency>
     </dependencies>
@@ -52,7 +60,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.7.0</version>
+                <version>${maven-compiler-plugin.version}</version>
                 <configuration>
                     <source>${source.level}</source>
                     <target>${target.level}</target>
@@ -63,7 +71,7 @@
             <plugin>
                 <groupId>com.google.cloud.tools</groupId>
                 <artifactId>jib-maven-plugin</artifactId>
-                <version>1.2.0</version>
+                <version>${jib-maven-plugin.version}</version>
                 <configuration>
                     <from>
                         <image>gcr.io/distroless/java:debug</image>
@@ -75,9 +83,9 @@
                         <jvmFlags>
                             <jvmFlag>-Djava.net.preferIPv4Stack=true</jvmFlag>
                         </jvmFlags>
-                        <mainClass>org.apache.dubbo.samples.provider.Application</mainClass>
+                        <mainClass>${man-class}</mainClass>
                         <ports>
-                            <port>20880</port>
+                            <port>${dubbo.port}</port>
                         </ports>
                     </container>
                 </configuration>
@@ -94,14 +102,14 @@
             <plugin>
                 <groupId>io.fabric8</groupId>
                 <artifactId>docker-maven-plugin</artifactId>
-                <version>0.30.0</version>
+                <version>${docker-maven-plugin.version}</version>
                 <configuration>
                     <images>
                         <image>
-                            <name>dubbo-samples-api:${dubbo.version}</name>
+                            <name>${image.name}:${dubbo.version}</name>
                             <run>
                                 <ports>
-                                    <port>20880:20880</port>
+                                    <port>${dubbo.port}:${dubbo.port}</port>
                                 </ports>
                             </run>
                         </image>
@@ -129,7 +137,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
-                <version>3.0.0-M3</version>
+                <version>${maven-failsafe-plugin.version}</version>
                 <executions>
                     <execution>
                         <goals>
@@ -141,7 +149,7 @@
                                 <java.net.preferIPv4Stack>true</java.net.preferIPv4Stack>
                             </systemPropertyVariables>
                             <includes>
-                                <include>**/*IT.*</include>
+                                <include>**/*IT.java</include>
                             </includes>
                         </configuration>
                     </execution>


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org