[jira] [Updated] (AMBARI-6951) BE: Bad request error thrown during configs-validation

["Srimanth Gunturi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMBARI-6951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Srimanth Gunturi updated AMBARI-6951:
-------------------------------------

    Attachment: AMBARI-6951.patch

Review at https://reviews.apache.org/r/24901/

> BE: Bad request error thrown during configs-validation
> ------------------------------------------------------
>
>                 Key: AMBARI-6951
>                 URL: https://issues.apache.org/jira/browse/AMBARI-6951
>             Project: Ambari
>          Issue Type: Bug
>          Components: controller
>    Affects Versions: 1.7.0
>            Reporter: Srimanth Gunturi
>            Assignee: Srimanth Gunturi
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-6951.patch
>
>
> A request for validate-configs threw a 400-Bad Request exception because one of the services in input (STORM) didnt have any recommendations (Attaching request).
> {code}
> 01:21:30,455  INFO [qtp1119389677-24] StackAdvisorRunner:48 - Script=/var/lib/ambari-server/resources/scripts/stack_advisor.py, actionDirectory=/var/run/ambari-server/stack-recommendations/75, command=validate-configurations
> 01:21:30,460  INFO [qtp1119389677-24] StackAdvisorRunner:62 - Stack-advisor output=/var/run/ambari-server/stack-recommendations/75/stackadvisor.out, error=/var/run/ambari-server/stack-recommendations/75/stackadvisor.err
> 01:21:30,500  INFO [qtp1119389677-24] StackAdvisorRunner:68 - Stack advisor output files
> 01:21:30,501  INFO [qtp1119389677-24] StackAdvisorRunner:69 -     advisor script stdout: StackAdvisor implementation for stack HDP, version 2.0.6 was loaded
> StackAdvisor implementation for stack HDP, version 2.1 was loaded
> Error occured in stack advisor.
> Error details: 'storm-site'
> 01:21:30,501  INFO [qtp1119389677-24] StackAdvisorRunner:70 -     advisor script stderr: Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 145, in <module>
>     main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 106, in main
>     result = stackAdvisor.validateConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 404, in validateConfigurations
>     resultItems = method(getSiteProperties(configurations, siteName), recommendedDefaults[siteName]["properties"])
> KeyError: 'storm-site'
> 01:21:30,501  WARN [qtp1119389677-24] StackAdvisorCommand:211 - Stack advisor script finished with errors
> {code}
> The validation API should tolerate
> # services with no recommendations 
> # services with no configurations input (config-type key not provided)
> The second case happens when I am editing only YARN service configs, and I do not have configs for all the other services. In such a case, the configs-validation call is made with only YARN config-types (yarn-env, yarn-site, etc.). All other config-types are not provided. So for such a call, validation for other services (Oozie, HDFS, etc. should not be performed). So, basically we validate a service configs, only if its config-types are present.



--
This message was sent by Atlassian JIRA
(v6.2#6252)