You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/05/28 14:26:09 UTC

[GitHub] [commons-text] ValentijnvdBeek edited a comment on pull request #132: (doc) Fix a buffer overflow bug in checkCapacity

ValentijnvdBeek edited a comment on pull request #132:
URL: https://github.com/apache/commons-text/pull/132#issuecomment-635382634


   @garydgregory
   
   That is good point, I have changed it so when it overflows it will put the value at the maximum value possible which similar to how OpenJDK does it. I also put the bound as a separate variable so we don't have to recompute it. 
   
   Is this more along the lines of what you would like? Also, I forced pushed it but I know that opinions on this differ so tell me if you want me to avoid it in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org