You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/26 00:07:12 UTC

[jira] [Commented] (FLINK-3811) Refactor ExecutionEnvironment in TableEnvironment

    [ https://issues.apache.org/jira/browse/FLINK-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257140#comment-15257140 ] 

ASF GitHub Bot commented on FLINK-3811:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/1930

    [FLINK-3811] [tableAPI] Use only Java ExecutionEnvironments in TableEnvironments

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableJavaEnv

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1930
    
----
commit 38d06e0922932dc835abaf460d293fa96e51e4fc
Author: Fabian Hueske <fh...@apache.org>
Date:   2016-04-25T16:58:23Z

    [FLINK-3811] [tableAPI] Use only Java ExecutionEnvironments in TableEnvironments.

----


> Refactor ExecutionEnvironment in TableEnvironment
> -------------------------------------------------
>
>                 Key: FLINK-3811
>                 URL: https://issues.apache.org/jira/browse/FLINK-3811
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> Currently, the Scala BatchTableEnvironment has a reference to a Scala ExecutionEnvironment and the Java BatchTableEnvironment uses the Java ExecutionEnvironment. The same applies to their streaming counterparts.
> This requires special implementations for Java / Scala for instance to create new data sources.
> I propose to refactor the TableEnvironments such that only the Java execution environments for batch and streaming are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)