You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/11/08 05:33:31 UTC
[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4991
Change subject: Enforce that REINSERTs are not supported in DeltaMemStores
......................................................................
Enforce that REINSERTs are not supported in DeltaMemStores
We never really supported REINSERTs in the delta memstore but had
code that seemed like we eventually would. This adds a CHECK to
make sure we never see REINSERTs in the DeltaMemStore and also
simplifies some of the code accordingly.
Change-Id: I04d0ea70969dcf60b3690d21122f3a9d497c29e3
---
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
2 files changed, 9 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/4991/1
--
To view, visit http://gerrit.cloudera.org:8080/4991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04d0ea70969dcf60b3690d21122f3a9d497c29e3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: Enforce that REINSERTs are not supported in DeltaMemStores
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04d0ea70969dcf60b3690d21122f3a9d497c29e3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Enforce that REINSERTs are not supported in DeltaMemStores
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Enforce that REINSERTs are not supported in DeltaMemStores
......................................................................
Enforce that REINSERTs are not supported in DeltaMemStores
We never really supported REINSERTs in the delta memstore but had
code that seemed like we eventually would. This adds a CHECK to
make sure we never see REINSERTs in the DeltaMemStore and also
simplifies some of the code accordingly.
Change-Id: I04d0ea70969dcf60b3690d21122f3a9d497c29e3
Reviewed-on: http://gerrit.cloudera.org:8080/4991
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/tablet/deltamemstore.cc
M src/kudu/tablet/deltamemstore.h
2 files changed, 9 insertions(+), 17 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4991
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04d0ea70969dcf60b3690d21122f3a9d497c29e3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>