You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/09/26 14:29:06 UTC
[PR] Add round trip tests for reading/writing parquet metadata [arrow-rs]
alamb opened a new pull request, #6463:
URL: https://github.com/apache/arrow-rs/pull/6463
Draft as this PR currently uses a Builder API that is not present
# Which issue does this PR close?
Part of
# Rationale for this change
@adriangb , @etseidl and myself were unclear what happens when parquet metadata that has been serialized directly with the ParquetMetaDataWriter: https://github.com/apache/arrow-rs/pull/6081/files#r1773996251
I figured the best way to find out was to write some tests for it 🤓
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No, just tests
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add round trip tests for reading/writing parquet metadata [arrow-rs]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #6463:
URL: https://github.com/apache/arrow-rs/pull/6463#issuecomment-2377345221
I think this PR or a subsequent one can also then delete this horrid tests: https://github.com/apache/arrow-rs/blob/2cc0c167d9725c1b1965980965d637928d887380/parquet/src/file/metadata/writer.rs#L416-L676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add round trip tests for reading/writing parquet metadata [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #6463:
URL: https://github.com/apache/arrow-rs/pull/6463#discussion_r1777664937
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -377,300 +377,3 @@ impl<'a, W: Write> ParquetMetaDataWriter<'a, W> {
}
}
}
-
-#[cfg(test)]
Review Comment:
Removed per @adriangb 's comment: https://github.com/apache/arrow-rs/pull/6463#issuecomment-2377345221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add round trip tests for reading/writing parquet metadata [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6463:
URL: https://github.com/apache/arrow-rs/pull/6463#issuecomment-2377819082
> I think this PR or a subsequent one can also then delete these tests that I wrote before we had the dedicated reader:
Good idea, I did it in 904596859b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org