[GitHub] [beam] dpcollins-google commented on a change in pull request #17094: [BEAM-14116] Catch MonitoringInfoMetricName null keys or values in the constructor

[GitBox <gi...@apache.org>]

dpcollins-google commented on a change in pull request #17094:
URL: https://github.com/apache/beam/pull/17094#discussion_r830388174



##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -56,13 +58,13 @@ private MonitoringInfoMetricName(String urn, Map<String, String> labels) {
   public String getNamespace() {
     if (labels.containsKey(MonitoringInfoConstants.Labels.NAMESPACE)) {

Review comment:
       Done.

##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/MonitoringInfoMetricName.java
##########
@@ -33,9 +33,6 @@
  * key instead of only a name+namespace. This is useful when defining system defined metrics with a
  * specific urn via a {@code CounterContainer}.
  */
-@SuppressWarnings({
-  "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
-})
 public class MonitoringInfoMetricName extends MetricName {
 
   private String urn;

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org