You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2024/09/10 17:48:03 UTC
[PR] [SPARK-49574][CONNECT][SQL] ExpressionEncoder tracks the AgnosticEncoder that created it. [spark]
hvanhovell opened a new pull request, #48062:
URL: https://github.com/apache/spark/pull/48062
### What changes were proposed in this pull request?
This PR makes ExpressionEncoder track the AgnosticEncoder it is created from. The main reason for this change is to allow for situations where both Agnostic and ExpressionEncoders are used together.
### Why are the changes needed?
This is the first step in creating an shared Encoders object for Classic and Connect.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49574][CONNECT][SQL] ExpressionEncoder tracks the AgnosticEncoder that created it [spark]
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #48062:
URL: https://github.com/apache/spark/pull/48062#issuecomment-2344132138
Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49574][CONNECT][SQL] ExpressionEncoder tracks the AgnosticEncoder that created it [spark]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #48062: [SPARK-49574][CONNECT][SQL] ExpressionEncoder tracks the AgnosticEncoder that created it
URL: https://github.com/apache/spark/pull/48062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org