You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2026/08/25 10:49:23 UTC

Re: [PR] IGNITE-28374 Calcite. Fix SQL select by _key for a composite pk for key class [ignite]

zstan commented on code in PR #13225:
URL: https://github.com/apache/ignite/pull/13225#discussion_r3852214963


##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/UserDefinedFunctionsIntegrationTest.java:
##########
@@ -332,15 +332,18 @@ public void testTableFunctions() throws Exception {
         assertThrows("SELECT * from raiseException(?, ?, ?)", RuntimeException.class, "Test exception",
             1, "test", true);
 
+        var empObj1 = new Employer("emp1", 1000d);
+        var empObj10 = new Employer("emp10", 10000d);
+
         // Object type.
-        assertQuery("SELECT * from withObjectType(1)")
-            .returns(1, new Employer("emp1", 1000d))
-            .returns(10, new Employer("emp10", 10000d))
+        assertQuery("SELECT * from withObjectType(1) ORDER BY ID")
+            .returns(1, client.binary().toBinary(empObj1))

Review Comment:
   refactored



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org