[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #6728:
URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r606011115



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java
##########
@@ -40,22 +41,22 @@
 
   BOOLEAN {
     @Override
-    public Integer toInteger(Object value) {
+    public int toInt(Object value) {
       return ((Boolean) value) ? 1 : 0;
     }
 
     @Override
-    public Long toLong(Object value) {
+    public long toLong(Object value) {
       return ((Boolean) value) ? 1L : 0L;

Review comment:
       Both `1L` and `1l` represents the primitive long. We usually use capital `L` for long to differentiate it from `1`. Check the first answer here: https://stackoverflow.com/questions/769963/javas-l-number-long-specification




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org