You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:21:15 UTC
[GitHub] [buildstream] BuildStream-Migration-Bot opened a new pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
BuildStream-Migration-Bot opened a new pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418
[See original merge request on GitLab](https://gitlab.com/BuildStream/buildstream/-/merge_requests/1805)
In GitLab by [[Gitlab user @coldtom]](https://gitlab.com/coldtom) on Jan 17, 2020, 21:29
Backport of !1694
I'd like to use the bazel_build plugin in 1.4.x too, but unfortunately it requires this change. If this is deemed unsuitable to backport, I can handle it in the plugin. However doing so means we will mount in the host /dev/shm, which is a bit sad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#issuecomment-958854759
Closing in favor of #1533 where I'm adding some additional support and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#discussion_r740898037
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
Update, after discussing this on slack we will update this patch to also add yaml configuration for this for `BuildElement` and `ScriptElement` classes so that projects can easily enable creation of `/dev/shm`, since this is more urgent with glibc 2.34 as highlighted in #1525
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
Update: after discussing this on slack we will update this patch to also add yaml configuration for this for `BuildElement` and `ScriptElement` classes so that projects can easily enable creation of `/dev/shm`, since this is more urgent with glibc 2.34 as highlighted in #1525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#issuecomment-958854759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan closed pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan closed pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#issuecomment-773092092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] BuildStream-Migration-Bot commented on pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
BuildStream-Migration-Bot commented on pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#issuecomment-773092092
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan closed pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan closed pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#discussion_r740097380
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
It looks like this test does not actually test the new sandbox flag.
Ideally we should update the base image to use a new glibc and have a `BuildElement` plugin which exercises the new flag.
Let me see if I can update this quickly and get this merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#issuecomment-958854759
Closing in favor of #1533 where I'm adding some additional support and tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
nanonyme commented on pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#issuecomment-939715540
@juergbi I suggest this is pulled in to bst1.7 since it looks like bst2 shows no signs of itself. If this indeed breaks reproducibility, can be handled as bug fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#discussion_r740898037
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
Update, after discussing this on slack we will update this patch to also add yaml configuration for this for `BuildElement` and `ScriptElement` classes so that projects can easily enable creation of `/dev/shm`, since this is more urgent with glibc 2.34 as highlighted in #1525
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
Update: after discussing this on slack we will update this patch to also add yaml configuration for this for `BuildElement` and `ScriptElement` classes so that projects can easily enable creation of `/dev/shm`, since this is more urgent with glibc 2.34 as highlighted in #1525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on a change in pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan commented on a change in pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418#discussion_r740898037
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
Update, after discussing this on slack we will update this patch to also add yaml configuration for this for `BuildElement` and `ScriptElement` classes so that projects can easily enable creation of `/dev/shm`, since this is more urgent with glibc 2.34 as highlighted in #1525
##########
File path: tests/integration/project/elements/sandbox-bwrap/test-dev-shm.bst
##########
@@ -0,0 +1,15 @@
+kind: manual
Review comment:
Update: after discussing this on slack we will update this patch to also add yaml configuration for this for `BuildElement` and `ScriptElement` classes so that projects can easily enable creation of `/dev/shm`, since this is more urgent with glibc 2.34 as highlighted in #1525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan closed pull request #1418: Backport creation of /dev/shm in the sandbox to bst-1
Posted by GitBox <gi...@apache.org>.
gtristan closed pull request #1418:
URL: https://github.com/apache/buildstream/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org