You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/02/24 10:18:36 UTC
Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time
should accept variables.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57028/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
Bugs: AMBARI-20166
https://issues.apache.org/jira/browse/AMBARI-20166
Repository: ambari
Description
-------
Fixed by using existing date-with-expr component for nominal time instead of date field.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js bcc209b
contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 153b538
contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 9d90280
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 2ebc259
Diff: https://reviews.apache.org/r/57028/diff/
Testing
-------
Manual Testing
Thanks,
Padma Priya N
Re: Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time
should accept variables.
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57028/#review166669
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 24, 2017, 10:18 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57028/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 10:18 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20166
> https://issues.apache.org/jira/browse/AMBARI-20166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by using existing date-with-expr component for nominal time instead of date field.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js bcc209b
> contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 153b538
> contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 9d90280
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 2ebc259
>
> Diff: https://reviews.apache.org/r/57028/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>
Re: Review Request 57028: AMBARI-20166.Workflow Manager. Nominal time
should accept variables.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57028/#review166675
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 24, 2017, 10:18 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57028/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 10:18 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20166
> https://issues.apache.org/jira/browse/AMBARI-20166
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixed by using existing date-with-expr component for nominal time instead of date field.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/sla-info.js bcc209b
> contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 153b538
> contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js 9d90280
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 2ebc259
>
> Diff: https://reviews.apache.org/r/57028/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> Padma Priya N
>
>