[jira] Commented: (TS-141) Fix Targets for building, testing and packaging (dist,distcheck)

["Leif Hedstrom (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829700#action_12829700 ] 

Leif Hedstrom commented on TS-141:
----------------------------------

Couple of comments:

1) I don't think this ever makes any sense:

+DISTCHECK_CONFIGURE_FLAGS=--with-user=${DIST_BUILD_USER} --with-group=${DIST_BUILD_USER}


I don't know of any Unix flavor that defaults the group to be the same as the user name. So that --with-group is almost always certain to not be correct (I don't know if it'll do anything wrong, but it's certainly rarely going to be correct).


2) I see there's another place here now for a version number, there's at least one more place with it, proxy/TS_version. Is there any way we can "unify" this into one place only? Maybe something holding both a short and longer description, e.g.

2.0.0a  <tab>   2.0.0-alpha   <tab>   Apache Traffic Server 2.0.0-alpha


> Fix Targets for building, testing and packaging (dist,distcheck)
> ----------------------------------------------------------------
>
>                 Key: TS-141
>                 URL: https://issues.apache.org/jira/browse/TS-141
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.0.0a
>         Environment: All
>            Reporter: George Paul
>            Assignee: George Paul
>             Fix For: 2.0.0a
>
>         Attachments: 0001-TS141_patch1.diff.patch
>
>
> Fix Targets for building, testing and packaging. Ensure make targets for 'dist' and 'distcheck' work before release.
> -George

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.