You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:02:57 UTC
[GitHub] [doris] ChPi opened a new pull request, #13775: [fix](Vectorized)fix json_object and json_array function return wrong result on vectorized engine
ChPi opened a new pull request, #13775:
URL: https://github.com/apache/doris/pull/13775
# Proposed changes
Issue Number: close #13598
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ChPi commented on pull request #13775: [fix](Vectorized)fix json_object and json_array function return wrong result on vectorized engine
Posted by GitBox <gi...@apache.org>.
ChPi commented on PR #13775:
URL: https://github.com/apache/doris/pull/13775#issuecomment-1296589360
the p0 check would be failed before using `reset`, and add this reset code (1f69f94), it is successful.
but test by myself on previous version(master and 1.1) without this reset code would be success
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13775: [fix](Vectorized)fix json_object and json_array function return wrong result on vectorized engine
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13775:
URL: https://github.com/apache/doris/pull/13775#issuecomment-1308156259
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13775: [fix](Vectorized)fix json_object and json_array function return wrong result on vectorized engine
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13775:
URL: https://github.com/apache/doris/pull/13775#issuecomment-1295067370
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.34 seconds
load time: 567 seconds
storage size: 17154644876 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028142520_clickbench_pr_35483.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #13775: [fix](Vectorized)fix json_object and json_array function return wrong result on vectorized engine
Posted by GitBox <gi...@apache.org>.
morningman merged PR #13775:
URL: https://github.com/apache/doris/pull/13775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13775: [fix](Vectorized)fix json_object and json_array function return wrong result on vectorized engine
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13775:
URL: https://github.com/apache/doris/pull/13775#issuecomment-1308156288
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org