You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by Han G <dh...@hotmail.com> on 2022/06/01 11:04:51 UTC
fix issue that can't run sofa application using zk registration
Hi folks,
For #3461<https://github.com/apache/incubator-shenyu/issues/3461> , the root cause is because the curator version used in sofa (ver 4.0.1) is not compatible with 5.2.1. Here’s the link of PR. https://github.com/apache/incubator-shenyu/pull/3470
Welcome to have a try/test and let me know if any issue. I’ve tested in my local environment.
To fix this issue, there're several options,
1. Downgrade curator version in bootstrap. It will succeed to run sofa applications, but will failed to sync data based on zookeeper for bootstrap. I can create another PR to find any walk around to fix it in bootstrap.
2. The other option is tell customers in official documents about this, and let them add ver 4.0.1 curator dependencies by themselves. And let them know the pros and cons.
This PR is follow option 1, it added curator ver 4.0.1 into bootstrap pom file, and I'll create another PR to fix the data sync issue in bootstrap when using 4.0.1.
There're also some other changes, since the sofa-example are out-of-date and are using curator 2.9.1, which even can't not start up. So I upgraded to sofa version 3.12.1, which is released by Apr. 2022.
Please let me know if any suggestion. Prefer #1 or #2. Anyway, the `sofa-example` need to be updated. Thank you for your time!
Thanks,
Han
Re: fix issue that can't run sofa application using zk registration
Posted by Han G <dh...@hotmail.com>.
Hi folks,
After the former PR has been merged, I created a new PR to fix the zk sync issue in bootstrap because of Curator version incompatible. Please help to review and test, and feel free to let me know if any comment. Thank you!
ISSUE: https://github.com/apache/incubator-shenyu/issues/3475
PR: https://github.com/apache/incubator-shenyu/pull/3476
Thanks,
Han
From: Han G <dh...@hotmail.com>
Date: Wednesday, June 1, 2022 at 19:04
To: dev <de...@shenyu.apache.org>
Subject: fix issue that can't run sofa application using zk registration
Hi folks,
For #3461<https://github.com/apache/incubator-shenyu/issues/3461> , the root cause is because the curator version used in sofa (ver 4.0.1) is not compatible with 5.2.1. Here’s the link of PR. https://github.com/apache/incubator-shenyu/pull/3470
Welcome to have a try/test and let me know if any issue. I’ve tested in my local environment.
To fix this issue, there're several options,
1. Downgrade curator version in bootstrap. It will succeed to run sofa applications, but will failed to sync data based on zookeeper for bootstrap. I can create another PR to find any walk around to fix it in bootstrap.
2. The other option is tell customers in official documents about this, and let them add ver 4.0.1 curator dependencies by themselves. And let them know the pros and cons.
This PR is follow option 1, it added curator ver 4.0.1 into bootstrap pom file, and I'll create another PR to fix the data sync issue in bootstrap when using 4.0.1.
There're also some other changes, since the sofa-example are out-of-date and are using curator 2.9.1, which even can't not start up. So I upgraded to sofa version 3.12.1, which is released by Apr. 2022.
Please let me know if any suggestion. Prefer #1 or #2. Anyway, the `sofa-example` need to be updated. Thank you for your time!
Thanks,
Han