You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by iv-m <gi...@git.apache.org> on 2017/05/09 12:27:49 UTC
[GitHub] kafka pull request #3002: KAFKA-5203: Metrics: fix resetting of histogram sa...
GitHub user iv-m opened a pull request:
https://github.com/apache/kafka/pull/3002
KAFKA-5203: Metrics: fix resetting of histogram sample
Without the histogram cleanup, the percentiles are calculated
incorrectly after purging of one or more samples: event counts
go out of sync with counts in histogram buckets, and bucket
with lower value gets chosen for the given quantile.
This change adds the necessary histogram cleanup.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iv-m/kafka kafka-5203-percentiles-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3002.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3002
----
commit 07c176a23ea11b6ba7a103d8aaf4867591ba9293
Author: Ivan A. Melnikov <iv...@altlinux.org>
Date: 2017-05-09T12:15:27Z
KAFKA-5203: Metrics: fix resetting of histogram sample
Without the histogram cleanup, the percentiles are calculated
incorrectly after purging of one or more samples: event counts
go out of sync with counts in histogram buckets, and bucket
with lower value gets chosen for the given quantile.
This change adds the necessary histogram cleanup.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #3002: KAFKA-5203: Metrics: fix resetting of histogram sa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---