You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/29 12:42:22 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #6308: Python: Make types required
Fokko opened a new pull request, #6308:
URL: https://github.com/apache/iceberg/pull/6308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6308: Python: Make types required
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6308:
URL: https://github.com/apache/iceberg/pull/6308#discussion_r1035050287
##########
python/pyiceberg/io/__init__.py:
##########
@@ -91,11 +96,13 @@ def close(self) -> None:
...
@abstractmethod
- def __enter__(self):
+ def __enter__(self) -> BufferedReader:
Review Comment:
Isn't this an open `OutputStream`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #6308: Python: Make types required
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #6308:
URL: https://github.com/apache/iceberg/pull/6308#discussion_r1035051325
##########
python/pyiceberg/expressions/visitors.py:
##########
@@ -505,7 +505,7 @@ class _ManifestEvalVisitor(BoundBooleanExpressionVisitor[bool]):
partition_fields: List[PartitionFieldSummary]
partition_filter: BooleanExpression
- def __init__(self, partition_struct_schema: Schema, partition_filter: BooleanExpression, case_sensitive):
+ def __init__(self, partition_struct_schema: Schema, partition_filter: BooleanExpression, case_sensitive: bool) -> None:
Review Comment:
Doesn't this return `_ManifestEvalVisitor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #6308: Python: Make types required
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #6308:
URL: https://github.com/apache/iceberg/pull/6308#issuecomment-1341648673
Thanks, @Fokko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #6308: Python: Make types required
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #6308:
URL: https://github.com/apache/iceberg/pull/6308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #6308: Python: Make types required
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #6308:
URL: https://github.com/apache/iceberg/pull/6308#discussion_r1035062373
##########
python/pyiceberg/io/__init__.py:
##########
@@ -91,11 +96,13 @@ def close(self) -> None:
...
@abstractmethod
- def __enter__(self):
+ def __enter__(self) -> BufferedReader:
Review Comment:
You're right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org