You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/09 02:59:04 UTC
[GitHub] [flink] guoweiM opened a new pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
guoweiM opened a new pull request #13358:
URL: https://github.com/apache/flink/pull/13358
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
1. Change the help messages of -m parameter of `DefaultCLI` and `FlinkYarnSessionCli`.
2. Document that "rest.address" and "rest.address.port" is respected only if the high-availability is NONE.
## Brief change log
- Remove the "-m" options from the `AbstractCustomCommandLine `
- Add the "-m" options to `DefaultCLI` and add some description`This option is respected only if the high-availability is NONE.`
- Add the "-m" options to `FlinkYarnSessionCli` and add some description `Specify the yarn cluster mode if the argument equals yarn-cluster`
- Document that "rest.address" and "rest.address.port" is respected only if the high-availability is NONE.
## Verifying this change
Verify the help message manually.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (docs)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689269505
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 34e6524648d45b6806245e8e44c52c3321f2c21e (Fri Feb 19 07:24:31 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13358:
URL: https://github.com/apache/flink/pull/13358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30192c3868c507f128d525cfe4db23f573c9f22a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
guoweiM edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-693251822
Thanks for your reviewing. I would split the document change to another two commits. I think this would make the change more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689269505
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit af452f632d2b733634a88f2a91c65fe9837f99d6 (Wed Sep 09 03:00:39 UTC 2020)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-697264847
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
}, {
"hash" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582",
"triggerID" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6e6e94da73c668aa873d7155aae158418f6bc2f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af452f632d2b733634a88f2a91c65fe9837f99d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af452f632d2b733634a88f2a91c65fe9837f99d6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359)
* 30192c3868c507f128d525cfe4db23f573c9f22a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* af452f632d2b733634a88f2a91c65fe9837f99d6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
}, {
"hash" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30192c3868c507f128d525cfe4db23f573c9f22a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543)
* f6e6e94da73c668aa873d7155aae158418f6bc2f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
}, {
"hash" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582",
"triggerID" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"triggerType" : "PUSH"
}, {
"hash" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6e6e94da73c668aa873d7155aae158418f6bc2f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582)
* 34e6524648d45b6806245e8e44c52c3321f2c21e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
}, {
"hash" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582",
"triggerID" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"triggerType" : "PUSH"
}, {
"hash" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6838",
"triggerID" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"triggerType" : "PUSH"
}, {
"hash" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6840",
"triggerID" : "697264847",
"triggerType" : "MANUAL"
}, {
"hash" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6840",
"triggerID" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34e6524648d45b6806245e8e44c52c3321f2c21e Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6838) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6840)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-697516447
Thanks! I merged this 👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
}, {
"hash" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582",
"triggerID" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30192c3868c507f128d525cfe4db23f573c9f22a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543)
* f6e6e94da73c668aa873d7155aae158418f6bc2f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] guoweiM commented on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
guoweiM commented on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-693251822
Thanks for your reviewing. I would split the document change to another commit. I think this would make the change more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #13358:
URL: https://github.com/apache/flink/pull/13358#discussion_r488636093
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java
##########
@@ -66,7 +66,7 @@
key("rest.address")
.noDefaultValue()
.withFallbackKeys(JobManagerOptions.ADDRESS.key())
- .withDescription("The address that should be used by clients to connect to the server.");
+ .withDescription("The address that should be used by clients to connect to the server. Attention: This option is respected only if the high-availability is NONE.");
Review comment:
```suggestion
.withDescription("The address that should be used by clients to connect to the server. Attention: This option is respected only if the high-availability configuration is NONE.");
```
##########
File path: flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java
##########
@@ -79,7 +79,7 @@
.withDeprecatedKeys(WebOptions.PORT.key())
.withDescription(
Description.builder()
- .text("The port that the client connects to. If %s has not been specified, then the REST server will bind to this port.", text(BIND_PORT.key()))
+ .text("The port that the client connects to. If %s has not been specified, then the REST server will bind to this port. Attention: This option is respected only if the high-availability is NONE.", text(BIND_PORT.key()))
Review comment:
```suggestion
.text("The port that the client connects to. If %s has not been specified, then the REST server will bind to this port. Attention: This option is respected only if the high-availability configuration is NONE.", text(BIND_PORT.key()))
```
##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java
##########
@@ -18,16 +18,30 @@
package org.apache.flink.client.cli;
+import org.apache.flink.client.deployment.executors.RemoteExecutor;
import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.DeploymentOptions;
+import org.apache.flink.util.FlinkException;
+import org.apache.flink.util.NetUtils;
import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.Option;
import org.apache.commons.cli.Options;
+import java.net.InetSocketAddress;
+
+import static org.apache.flink.client.cli.CliFrontend.setJobManagerAddressInConfig;
+
/**
* The default CLI which is used for interaction with standalone clusters.
*/
public class DefaultCLI extends AbstractCustomCommandLine {
+ private static final Option addressOption = new Option("m", "jobmanager", true,
+ "Address of the JobManager to which to connect. " +
+ "Use this flag to connect to a different JobManager than the one specified in the configuration. " +
+ "Attention: This option is respected only if the high-availability is NONE.");
Review comment:
```suggestion
"Attention: This option is respected only if the high-availability configuration is NONE.");
```
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/AbstractYarnCli.java
##########
@@ -0,0 +1,50 @@
+package org.apache.flink.yarn.cli;
+
+import org.apache.flink.client.cli.AbstractCustomCommandLine;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.configuration.DeploymentOptions;
+import org.apache.flink.yarn.configuration.YarnConfigOptions;
+import org.apache.flink.yarn.executors.YarnJobClusterExecutor;
+import org.apache.flink.yarn.executors.YarnSessionClusterExecutor;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+
+abstract class AbstractYarnCli extends AbstractCustomCommandLine {
+
+ private static final String ID = "yarn-cluster";
+
+ protected Option applicationId =
+ new Option("yid", "yarnapplicationId", true, "Attach to running YARN session");
+
+ protected Option addressOption =
+ new Option("m", "jobmanager", true, "Specify the yarn cluster mode if the argument equals " + ID);
Review comment:
```suggestion
new Option("m", "jobmanager", true, "Set to " + ID + " to use YARN execution mode.");
```
This option will be deprecated at some point because we now also have `--target` and the `GenericCli`. It's good to have it like this for now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13358: [FLINK-11779] CLI ignores -m parameter if high-availability is ZOOKEEPER
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13358:
URL: https://github.com/apache/flink/pull/13358#issuecomment-689274090
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6359",
"triggerID" : "af452f632d2b733634a88f2a91c65fe9837f99d6",
"triggerType" : "PUSH"
}, {
"hash" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6543",
"triggerID" : "30192c3868c507f128d525cfe4db23f573c9f22a",
"triggerType" : "PUSH"
}, {
"hash" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582",
"triggerID" : "f6e6e94da73c668aa873d7155aae158418f6bc2f",
"triggerType" : "PUSH"
}, {
"hash" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6838",
"triggerID" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"triggerType" : "PUSH"
}, {
"hash" : "34e6524648d45b6806245e8e44c52c3321f2c21e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6840",
"triggerID" : "697264847",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f6e6e94da73c668aa873d7155aae158418f6bc2f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6582)
* 34e6524648d45b6806245e8e44c52c3321f2c21e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6838) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6840)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org