[PR] refactor(validation): remove unused zOneOf helper [apisix-dashboard]

["Jaswanth-arjun (via GitHub)" <gi...@apache.org>]

Jaswanth-arjun opened a new pull request, #3339:
URL: https://github.com/apache/apisix-dashboard/pull/3339

   ### Problem
   zOneOf helper was reported to have incorrect behavior, but it is not used anywhere in the codebase.
   
   ### Solution
   Removed the unused helper function from src/utils/zod.ts.
   
   ### Result
   Improves code maintainability and removes dead code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(validation): remove unused zOneOf helper [apisix-dashboard]

["bzp2010 (via GitHub)" <gi...@apache.org>]

bzp2010 commented on PR #3339:
URL: https://github.com/apache/apisix-dashboard/pull/3339#issuecomment-4103227281

   Your edits go beyond the scope you claimed. Please check and remove any unnecessary parts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor(validation): remove unused zOneOf helper [apisix-dashboard]

["Jaswanth-arjun (via GitHub)" <gi...@apache.org>]

Jaswanth-arjun commented on PR #3339:
URL: https://github.com/apache/apisix-dashboard/pull/3339#issuecomment-4103431221

   Thanks for the review. @bzp2010 
   
   I re-checked current master and confirmed that zOneOf is no longer present in src/utils/zod.ts (only zGetDefault is exported), and there are no call sites for zOneOf in the codebase.
   
   So this report is outdated on current master and not actionable as a behavior fix now.
   I will close/withdraw this as not applicable to the current code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org