[jira] [Commented] (METRON-1808) Add Ansible created pyc to gitignore

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640169#comment-16640169 ] 

ASF GitHub Bot commented on METRON-1808:
----------------------------------------

GitHub user justinleet opened a pull request:

    https://github.com/apache/metron/pull/1228

    METRON-1808: Add Ansible created pyc to gitignore

    ## Contributor Comments
    Added *.pyc to gitignore for metron-development.  We don't need to commit pyc files.
    
    Ansible creates a pyc file (0_minimum_ansible_version.pyc) that isn't filtered by gitignore. I added the general pyc ignore, because I don't we care about committing pyc files at all.
    
    After running up full dev to create the file., this file should no longer be picked up by git.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/justinleet/metron gitignore

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1228
    
----
commit 3eba1ecced27ab4b4c302e77ba2878a2bd9d8bdb
Author: justinjleet <ju...@...>
Date:   2018-10-05T18:06:48Z

    Adding ignore pyc

----


> Add Ansible created pyc to gitignore
> ------------------------------------
>
>                 Key: METRON-1808
>                 URL: https://issues.apache.org/jira/browse/METRON-1808
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Justin Leet
>            Assignee: Justin Leet
>            Priority: Major
>
> Want to get rid of 
> {code}
> {14:06}~/Documents/workspace/metron:master ✗ ➭ git status
> On branch master
> Your branch is up to date with 'origin/master'.
> Untracked files:
>   (use "git add <file>..." to include in what will be committed)
> 	metron-deployment/ansible/callback_plugins/0_minimum_ansible_version.pyc
> nothing added to commit but untracked files present (use "git add" to track)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)