You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/22 17:43:29 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #38755: [SPARK-41221][SQL] Add the error class `INVALID_FORMAT`
MaxGekk commented on code in PR #38755:
URL: https://github.com/apache/spark/pull/38755#discussion_r1029650857
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -687,6 +647,63 @@
],
"sqlState" : "42000"
},
+ "INVALID_FORMAT" : {
Review Comment:
> Do we want this to be generic or specific to numbers.
I want to believe that we can make it as a generic error class. I have already merged `LIKE ...` errors into it.
I think there is the common part where we declare that the format is invalid and show it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org