You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2016/03/07 21:12:36 UTC
Can we please kill the Battery Plugin on Android
Hey
Once again, I ran into someone using the Battery Plugin that actively kills
the Battery on Android, and can we please discourage people from using this
very broken plugin that we have no ability or intention of fixing?
The reason I don't want to fix it because the browser already supports it
on the latest versions of Chromium, and because it's impossible to fix
without changing the API entirely. We really need to kick this harmful
plugin to the curb so that people stop making applications that drain the
battery of their devices.
I know that we've talked about it at length, but I don't ever remember us
coming to a conclusion regarding killing the battery plugin on Android.
Any thoughts?
Joe
Re: Can we please kill the Battery Plugin on Android
Posted by Carlos Santana <cs...@gmail.com>.
+1 API for android can be remove from plugin with major bump version of the plugin.
I would say that would start the clock for the six months support for the previous version. A patch release can be done to mark API deprecated for those picking only minor and patch to start getting the warning.
- Carlos
@csantanapr
> On Mar 8, 2016, at 1:11 AM, Joe Bowser <bo...@gmail.com> wrote:
>
> Actually, we already document this as clear as possible in the README.md
> for the plugin. I think this is a very serious understatement.
>
> https://github.com/apache/cordova-plugin-battery-status
>
>
>> On Mon, Mar 7, 2016 at 10:09 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>
>>
>> On Mon, Mar 7, 2016 at 10:00 PM, Nikhil Khandelwal <nikhilkh@microsoft.com
>>> wrote:
>>
>>> What's our deprecation policy? Should we log a deprecation message before
>>> remove this support. What alternatives do Cordova developers have - are
>>> there other plugins which provide the equivalent functionality - perhaps
>>> with a better API - as opposed to polling events every 1% battery drop.
>>
>> Our regular deprecation policy is six months, but I think we should bypass
>> that because our Battery Plugin on Android is harmful and will kill the
>> battery in two hours if left running.
>>
>> Chrome 38 has support for the W3C Battery API, but there's still not an
>> option for people stuck on 4.4 or below other than to use Crosswalk. The
>> thing is that a size penalty is still better than a battery that actually
>> drains the battery of the phone.
>>
>> You could do a scaled-down API where it only sends an event when the
>> battery is at 15% and has no meta information, but it wouldn't be
>> compatible with the W3C and I remember criticizing the W3C spec as being
>> unable to be implemented in Cordova by itself, since the Android SDK
>> requires us to subscribe to an event manually that is never meant to be
>> subscribed to. AFAIK, the community hasn't created a third party battery
>> plugin that works. I don't want us to keep distributing a plugin that is
>> so completely broken that it's harmful for users. I don't care how many
>> developers use it, since they're obviously not testing their applications.
>>
>>
>>
>>>
>>> -Nikhil
>>>
>>> -----Original Message-----
>>> From: Shazron [mailto:shazron@gmail.com]
>>> Sent: Monday, March 7, 2016 5:27 PM
>>> To: dev@cordova.apache.org
>>> Subject: Re: Can we please kill the Battery Plugin on Android
>>>
>>> +1
>>> If no one has concerns by the end of the week, I'd say we would have lazy
>>> consensus and you can delete the Android part of the plugin (maybe prep the
>>> PR now)
>>>
>>>> On Mon, Mar 7, 2016 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
>>>> Hey
>>>>
>>>> Once again, I ran into someone using the Battery Plugin that actively
>>>> kills the Battery on Android, and can we please discourage people from
>>>> using this very broken plugin that we have no ability or intention of
>>> fixing?
>>>>
>>>> The reason I don't want to fix it because the browser already supports
>>>> it on the latest versions of Chromium, and because it's impossible to
>>>> fix without changing the API entirely. We really need to kick this
>>>> harmful plugin to the curb so that people stop making applications
>>>> that drain the battery of their devices.
>>>>
>>>> I know that we've talked about it at length, but I don't ever remember
>>>> us coming to a conclusion regarding killing the battery plugin on
>>> Android.
>>>>
>>>> Any thoughts?
>>>>
>>>> Joe
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Can we please kill the Battery Plugin on Android
Posted by Joe Bowser <bo...@gmail.com>.
Actually, we already document this as clear as possible in the README.md
for the plugin. I think this is a very serious understatement.
https://github.com/apache/cordova-plugin-battery-status
On Mon, Mar 7, 2016 at 10:09 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>
> On Mon, Mar 7, 2016 at 10:00 PM, Nikhil Khandelwal <nikhilkh@microsoft.com
> > wrote:
>
>> What's our deprecation policy? Should we log a deprecation message before
>> remove this support. What alternatives do Cordova developers have - are
>> there other plugins which provide the equivalent functionality - perhaps
>> with a better API - as opposed to polling events every 1% battery drop.
>>
>
> Our regular deprecation policy is six months, but I think we should bypass
> that because our Battery Plugin on Android is harmful and will kill the
> battery in two hours if left running.
>
> Chrome 38 has support for the W3C Battery API, but there's still not an
> option for people stuck on 4.4 or below other than to use Crosswalk. The
> thing is that a size penalty is still better than a battery that actually
> drains the battery of the phone.
>
> You could do a scaled-down API where it only sends an event when the
> battery is at 15% and has no meta information, but it wouldn't be
> compatible with the W3C and I remember criticizing the W3C spec as being
> unable to be implemented in Cordova by itself, since the Android SDK
> requires us to subscribe to an event manually that is never meant to be
> subscribed to. AFAIK, the community hasn't created a third party battery
> plugin that works. I don't want us to keep distributing a plugin that is
> so completely broken that it's harmful for users. I don't care how many
> developers use it, since they're obviously not testing their applications.
>
>
>
>>
>> -Nikhil
>>
>> -----Original Message-----
>> From: Shazron [mailto:shazron@gmail.com]
>> Sent: Monday, March 7, 2016 5:27 PM
>> To: dev@cordova.apache.org
>> Subject: Re: Can we please kill the Battery Plugin on Android
>>
>> +1
>> If no one has concerns by the end of the week, I'd say we would have lazy
>> consensus and you can delete the Android part of the plugin (maybe prep the
>> PR now)
>>
>> On Mon, Mar 7, 2016 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
>> > Hey
>> >
>> > Once again, I ran into someone using the Battery Plugin that actively
>> > kills the Battery on Android, and can we please discourage people from
>> > using this very broken plugin that we have no ability or intention of
>> fixing?
>> >
>> > The reason I don't want to fix it because the browser already supports
>> > it on the latest versions of Chromium, and because it's impossible to
>> > fix without changing the API entirely. We really need to kick this
>> > harmful plugin to the curb so that people stop making applications
>> > that drain the battery of their devices.
>> >
>> > I know that we've talked about it at length, but I don't ever remember
>> > us coming to a conclusion regarding killing the battery plugin on
>> Android.
>> >
>> > Any thoughts?
>> >
>> > Joe
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>
>
Re: Can we please kill the Battery Plugin on Android
Posted by Joe Bowser <bo...@gmail.com>.
On Mon, Mar 7, 2016 at 10:00 PM, Nikhil Khandelwal <ni...@microsoft.com>
wrote:
> What's our deprecation policy? Should we log a deprecation message before
> remove this support. What alternatives do Cordova developers have - are
> there other plugins which provide the equivalent functionality - perhaps
> with a better API - as opposed to polling events every 1% battery drop.
>
Our regular deprecation policy is six months, but I think we should bypass
that because our Battery Plugin on Android is harmful and will kill the
battery in two hours if left running.
Chrome 38 has support for the W3C Battery API, but there's still not an
option for people stuck on 4.4 or below other than to use Crosswalk. The
thing is that a size penalty is still better than a battery that actually
drains the battery of the phone.
You could do a scaled-down API where it only sends an event when the
battery is at 15% and has no meta information, but it wouldn't be
compatible with the W3C and I remember criticizing the W3C spec as being
unable to be implemented in Cordova by itself, since the Android SDK
requires us to subscribe to an event manually that is never meant to be
subscribed to. AFAIK, the community hasn't created a third party battery
plugin that works. I don't want us to keep distributing a plugin that is
so completely broken that it's harmful for users. I don't care how many
developers use it, since they're obviously not testing their applications.
>
> -Nikhil
>
> -----Original Message-----
> From: Shazron [mailto:shazron@gmail.com]
> Sent: Monday, March 7, 2016 5:27 PM
> To: dev@cordova.apache.org
> Subject: Re: Can we please kill the Battery Plugin on Android
>
> +1
> If no one has concerns by the end of the week, I'd say we would have lazy
> consensus and you can delete the Android part of the plugin (maybe prep the
> PR now)
>
> On Mon, Mar 7, 2016 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
> > Hey
> >
> > Once again, I ran into someone using the Battery Plugin that actively
> > kills the Battery on Android, and can we please discourage people from
> > using this very broken plugin that we have no ability or intention of
> fixing?
> >
> > The reason I don't want to fix it because the browser already supports
> > it on the latest versions of Chromium, and because it's impossible to
> > fix without changing the API entirely. We really need to kick this
> > harmful plugin to the curb so that people stop making applications
> > that drain the battery of their devices.
> >
> > I know that we've talked about it at length, but I don't ever remember
> > us coming to a conclusion regarding killing the battery plugin on
> Android.
> >
> > Any thoughts?
> >
> > Joe
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
RE: Can we please kill the Battery Plugin on Android
Posted by Nikhil Khandelwal <ni...@microsoft.com>.
What's our deprecation policy? Should we log a deprecation message before remove this support. What alternatives do Cordova developers have - are there other plugins which provide the equivalent functionality - perhaps with a better API - as opposed to polling events every 1% battery drop.
-Nikhil
-----Original Message-----
From: Shazron [mailto:shazron@gmail.com]
Sent: Monday, March 7, 2016 5:27 PM
To: dev@cordova.apache.org
Subject: Re: Can we please kill the Battery Plugin on Android
+1
If no one has concerns by the end of the week, I'd say we would have lazy consensus and you can delete the Android part of the plugin (maybe prep the PR now)
On Mon, Mar 7, 2016 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> Once again, I ran into someone using the Battery Plugin that actively
> kills the Battery on Android, and can we please discourage people from
> using this very broken plugin that we have no ability or intention of fixing?
>
> The reason I don't want to fix it because the browser already supports
> it on the latest versions of Chromium, and because it's impossible to
> fix without changing the API entirely. We really need to kick this
> harmful plugin to the curb so that people stop making applications
> that drain the battery of their devices.
>
> I know that we've talked about it at length, but I don't ever remember
> us coming to a conclusion regarding killing the battery plugin on Android.
>
> Any thoughts?
>
> Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: Can we please kill the Battery Plugin on Android
Posted by Shazron <sh...@gmail.com>.
+1
If no one has concerns by the end of the week, I'd say we would have
lazy consensus and you can delete the Android part of the plugin
(maybe prep the PR now)
On Mon, Mar 7, 2016 at 12:12 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> Once again, I ran into someone using the Battery Plugin that actively kills
> the Battery on Android, and can we please discourage people from using this
> very broken plugin that we have no ability or intention of fixing?
>
> The reason I don't want to fix it because the browser already supports it
> on the latest versions of Chromium, and because it's impossible to fix
> without changing the API entirely. We really need to kick this harmful
> plugin to the curb so that people stop making applications that drain the
> battery of their devices.
>
> I know that we've talked about it at length, but I don't ever remember us
> coming to a conclusion regarding killing the battery plugin on Android.
>
> Any thoughts?
>
> Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org