You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/14 01:53:30 UTC

[GitHub] [pulsar] momo-jun opened a new pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

momo-jun opened a new pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751


   1. PR#12403: restructure and optimize content for message chunking.
   2. PR#13108: add description for how to disable threshold check for parameter “loadBalancerNamespaceBundleMaxSessions”.
   3. PR#13043: add 4 new parameters for both Broker and Standalone; add a paragraph for configuring ZK batching operations and benchmark results in the ZK admin topic.
   4. Bug fix: remove the duplicate parameter “maxNumPartitionsPerPartitionedTopic” from the Standalone section of the Pulsar Configuration topic.
   5. Bug fix: fix the missing parameter table for global ZK (configuration store) and incomplete parameter table for local ZK by referencing the one in ZK section of the Pulsar Configuration topic.
   
   <!--
   ### Contribution Checklist
     
     - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
       Skip *Issue XYZ* if there is no associated github issue for this pull request.
       Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
   
   Fixes #<xyz>
   
   *(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
   
   Master Issue: #<xyz>
   
   ### Motivation
   
   
   *Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
   
   ### Modifications
   
   *Describe the modifications you've done.*
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   - [ ] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1014078165


   @momo-jun 
   
   1. as we discussed just now, for https://github.com/apache/pulsar/pull/13077, we need to add explanations for "backend services (Rocksdb and Etcd)"
   
       References: https://github.com/apache/pulsar/pull/13077 and search "rocksdb" in the PR page and find related info, e.g. https://github.com/apache/pulsar/pulls?q=rocksdb
   
   2. can you modify the PR title? It should be the summary of your PR changes, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1014078165






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1012733958


   @momo-jun before submitting this PR, did you preview the changes in your local environment? If so, can you add some screenshots of the preview in the PR description? So that reviewers can understand the changes quickly and clearly, thanks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet removed a comment on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet removed a comment on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1012708537


   Add docs for https://github.com/apache/pulsar/pull/13077


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1014078165






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a change in pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun commented on a change in pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#discussion_r786540559



##########
File path: site2/docs/reference-configuration.md
##########
@@ -634,7 +641,7 @@ You can set the log level and configuration in the  [log4j2.yaml](https://github
 |loadBalancerAutoBundleSplitEnabled|    |false|
 | loadBalancerAutoUnloadSplitBundlesEnabled | Enable/Disable automatic unloading of split bundles. | true |
 |loadBalancerNamespaceBundleMaxTopics|    |1000|
-|loadBalancerNamespaceBundleMaxSessions|    |1000|
+|loadBalancerNamespaceBundleMaxSessions|  Maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered. <br>To disable the threshold check, set the value to -1.  |1000|

Review comment:
       Thanks Yu. Will update.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet edited a comment on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet edited a comment on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1014078165


   @momo-jun 
   
   1. as we discussed just now, for https://github.com/apache/pulsar/pull/13077, we need to add explanations for "backend services (Rocksdb and Etcd)"
   
   2. can you modify the PR title? It should be the summary of your PR changes, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1020739839


   > @momo-jun Thanks for your PR! It looks good to me for the chunked message part. But this PR involves too many parts of changes. It would be better to split this big PR into multiple PRs. I suggest that the next time you submit a PR, you could make one PR do only one thing.
   
   Thanks for your suggestion. I will definitely do that next time. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a change in pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun commented on a change in pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#discussion_r786540651



##########
File path: site2/docs/reference-configuration.md
##########
@@ -296,12 +300,12 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
 |loadBalancerBrokerOverloadedThresholdPercentage| Usage threshold to determine a broker as over-loaded  |85|
 |loadBalancerResourceQuotaUpdateIntervalMinutes|  Interval to update namespace bundle resource quota |15|
 |loadBalancerBrokerComfortLoadLevelPercentage|  Usage threshold to determine a broker is having just right level of load  |65|
-|loadBalancerAutoBundleSplitEnabled|  enable/disable namespace bundle auto split  |false|
-|loadBalancerNamespaceBundleMaxTopics|  maximum topics in a bundle, otherwise bundle split will be triggered  |1000|
-|loadBalancerNamespaceBundleMaxSessions|  maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered  |1000|
-|loadBalancerNamespaceBundleMaxMsgRate| maximum msgRate (in + out) in a bundle, otherwise bundle split will be triggered  |1000|
-|loadBalancerNamespaceBundleMaxBandwidthMbytes| maximum bandwidth (in + out) in a bundle, otherwise bundle split will be triggered  |100|
-|loadBalancerNamespaceMaximumBundles| maximum number of bundles in a namespace  |128|
+|loadBalancerAutoBundleSplitEnabled|  Enable/disable namespace bundle auto split  |false|
+|loadBalancerNamespaceBundleMaxTopics|  Maximum topics in a bundle, otherwise bundle split will be triggered  |1000|
+|loadBalancerNamespaceBundleMaxSessions|  Maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered. <br>To disable the threshold check, set the value to -1.  |1000|

Review comment:
       Thanks Yu. Will update.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun edited a comment on pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun edited a comment on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1015246095


   Hi guys @RobertIndie @codelipenghui @rdhabalia  @merlimat , can you please review this PR for doc udpates? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1012708537


   Add docs for https://github.com/apache/pulsar/pull/13077


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1015246095


   Hi guys @RobertIndie @codelipenghui  @merlimat , can you please review this PR for doc udpates? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1015247593


   > @momo-jun
   > 
   > 1. as we discussed just now, for [PIP-45: Allow to configure metadata store URL in broker.conf #13077](https://github.com/apache/pulsar/pull/13077), we need to add explanations for "backend services (Rocksdb and Etcd)"
   >    References: [PIP-45: Allow to configure metadata store URL in broker.conf #13077](https://github.com/apache/pulsar/pull/13077) and search "rocksdb" in the PR page and find related info, e.g. https://github.com/apache/pulsar/pulls?q=rocksdb
   > 2. can you modify the PR title? It should be the summary of your PR changes, thanks
   > 3. can you @ related engineers to review this PR? (for example, @RobertIndie could you please review this PR? Thanks)
   
   Thanks Yu. I've modified the title and invited reviewers. For item1, I will open a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#discussion_r785599771



##########
File path: site2/docs/reference-configuration.md
##########
@@ -634,7 +641,7 @@ You can set the log level and configuration in the  [log4j2.yaml](https://github
 |loadBalancerAutoBundleSplitEnabled|    |false|
 | loadBalancerAutoUnloadSplitBundlesEnabled | Enable/Disable automatic unloading of split bundles. | true |
 |loadBalancerNamespaceBundleMaxTopics|    |1000|
-|loadBalancerNamespaceBundleMaxSessions|    |1000|
+|loadBalancerNamespaceBundleMaxSessions|  Maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered. <br>To disable the threshold check, set the value to -1.  |1000|

Review comment:
       ```suggestion
   |loadBalancerNamespaceBundleMaxSessions|  Maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered. <br />To disable the threshold check, set the value to -1.  |1000|
   ```

##########
File path: site2/docs/reference-configuration.md
##########
@@ -296,12 +300,12 @@ brokerServiceCompactionThresholdInBytes|If the estimated backlog size is greater
 |loadBalancerBrokerOverloadedThresholdPercentage| Usage threshold to determine a broker as over-loaded  |85|
 |loadBalancerResourceQuotaUpdateIntervalMinutes|  Interval to update namespace bundle resource quota |15|
 |loadBalancerBrokerComfortLoadLevelPercentage|  Usage threshold to determine a broker is having just right level of load  |65|
-|loadBalancerAutoBundleSplitEnabled|  enable/disable namespace bundle auto split  |false|
-|loadBalancerNamespaceBundleMaxTopics|  maximum topics in a bundle, otherwise bundle split will be triggered  |1000|
-|loadBalancerNamespaceBundleMaxSessions|  maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered  |1000|
-|loadBalancerNamespaceBundleMaxMsgRate| maximum msgRate (in + out) in a bundle, otherwise bundle split will be triggered  |1000|
-|loadBalancerNamespaceBundleMaxBandwidthMbytes| maximum bandwidth (in + out) in a bundle, otherwise bundle split will be triggered  |100|
-|loadBalancerNamespaceMaximumBundles| maximum number of bundles in a namespace  |128|
+|loadBalancerAutoBundleSplitEnabled|  Enable/disable namespace bundle auto split  |false|
+|loadBalancerNamespaceBundleMaxTopics|  Maximum topics in a bundle, otherwise bundle split will be triggered  |1000|
+|loadBalancerNamespaceBundleMaxSessions|  Maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered. <br>To disable the threshold check, set the value to -1.  |1000|

Review comment:
       ```suggestion
   |loadBalancerNamespaceBundleMaxSessions|  Maximum sessions (producers + consumers) in a bundle, otherwise bundle split will be triggered. <br />To disable the threshold check, set the value to -1.  |1000|
   
   ```
   
   instructions: https://docs.google.com/document/d/1IV35SI_F8G8cL-Vuzknc6RTGLK9_edRMpZpnrHvAWNs/edit#bookmark=id.wcmnciyvvq6p




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1014078165


   @momo-jun as we discussed just now, for https://github.com/apache/pulsar/pull/13077, we need to add explanations for "backend services (Rocksdb and Etcd)"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #13751: [Doc] Add 4 metadatastore parameters and a section for ZK batching operations; Improve content for chunking; Bug fixes and more

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1020739839


   > @momo-jun Thanks for your PR! It looks good to me for the chunked message part. But this PR involves too many parts of changes. It would be better to split this big PR into multiple PRs. I suggest that the next time you submit a PR, you could make one PR do only one thing.
   
   Thanks for your suggestion. I will definitely do that next time. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1012677458


   @momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #13751: [Docs] Doc updates for PR#12403, PR#13108 and PR#13043

Posted by GitBox <gi...@apache.org>.
momo-jun commented on pull request #13751:
URL: https://github.com/apache/pulsar/pull/13751#issuecomment-1012836846


   > @momo-jun before submitting this PR, did you preview the changes in your local environment? If so, can you add some screenshots of the preview in the PR description? So that reviewers can understand the changes quickly and clearly, thanks
   
   Thanks Yu. I've attached the screenshots of detailed changes, and added the links of each PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org