You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/06/01 18:36:53 UTC
[kudu-CR](branch-1.17.x) [tools] add bound http address into DaemonInfoPB
Hello Abhishek Chennaka,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19985
to review the following change.
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
[tools] add bound_http_address into DaemonInfoPB
This patch adds bound_http_address field into the DaemonInfoPB message.
The new field will be used by test scenarios in follow-up changelists.
Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Reviewed-on: http://gerrit.cloudera.org:8080/19912
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit eae0ebf91e94be8341a18cfbb8e4c9dca5d6ef47)
---
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
2 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/19985/1
--
To view, visit http://gerrit.cloudera.org:8080/19985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19985
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR](branch-1.17.x) [tools] add bound http address into DaemonInfoPB
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19985 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19985
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 02 Jun 2023 06:28:06 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] add bound http address into DaemonInfoPB
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19985 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
[tools] add bound_http_address into DaemonInfoPB
This patch adds bound_http_address field into the DaemonInfoPB message.
The new field will be used by test scenarios in follow-up changelists.
Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Reviewed-on: http://gerrit.cloudera.org:8080/19912
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit eae0ebf91e94be8341a18cfbb8e4c9dca5d6ef47)
Reviewed-on: http://gerrit.cloudera.org:8080/19985
Reviewed-by: Yingchun Lai <la...@apache.org>
Tested-by: Yingchun Lai <la...@apache.org>
---
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved; Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19985
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [tools] add bound http address into DaemonInfoPB
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19985 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19985
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 02 Jun 2023 17:54:28 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] add bound http address into DaemonInfoPB
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19985 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Patch Set 1: Verified+1
The failed test (SecurityITest.TestEncryptionWithKMSIntegration) seems not related.
--
To view, visit http://gerrit.cloudera.org:8080/19985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19985
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 02 Jun 2023 06:30:58 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [tools] add bound http address into DaemonInfoPB
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19985
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19985
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>