You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by "Andy LoPresto (JIRA)" <ji...@apache.org> on 2019/05/14 02:30:01 UTC

[jira] [Created] (NIFI-6296) Improve instructions on submitting PR commits

Andy LoPresto created NIFI-6296:
-----------------------------------

             Summary: Improve instructions on submitting PR commits
                 Key: NIFI-6296
                 URL: https://issues.apache.org/jira/browse/NIFI-6296
             Project: Apache NiFi
          Issue Type: Improvement
          Components: Documentation &amp; Website
    Affects Versions: 1.9.2
            Reporter: Andy LoPresto
            Assignee: Andy LoPresto


Some contributors have been confused about how to provide additional commits when a PR reviewer asks for changes because the Contributor Guide and PR template emphasize a "single, squashed commit". 

I'll update these documents to explain that the _initial_ commit should be a single, squashed commit, but additional changes should be made on the same branch and pushed (without force pushing/overwriting) so the reviewers can see the changes. The eventual committer will squash and rebase (unless this is non-trivial, in which case they can ask the author to perform this task). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)