You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2014/11/04 15:29:58 UTC

[04/18] git commit: Make a note of the remaining steps needed for reliable rebind + OSGi bundles.

Make a note of the remaining steps needed for reliable rebind + OSGi bundles.


Project: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/commit/b496958d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/tree/b496958d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/diff/b496958d

Branch: refs/heads/master
Commit: b496958d91567abb3a17ceaa84de645cbeeffd85
Parents: d716e2f
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Thu Oct 30 11:56:50 2014 +0200
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Thu Oct 30 11:56:50 2014 +0200

----------------------------------------------------------------------
 .../main/java/brooklyn/entity/rebind/RebindManagerImpl.java | 9 +++++++++
 1 file changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-brooklyn/blob/b496958d/core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java b/core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java
index 9f620d6..807e6fb 100644
--- a/core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java
+++ b/core/src/main/java/brooklyn/entity/rebind/RebindManagerImpl.java
@@ -504,6 +504,15 @@ public class RebindManagerImpl implements RebindManager {
             // the rebindContext. This should not affect normal production usage, because rebind is run
             // against a data-store that is not being written to by other brooklyn instance(s).
 
+            // TODO Rebinding to code in OSGi bundles:
+            // Inferring the catalog item id context:
+            //   * most of the time the creator will be passing "my catalog item id" 
+            //     (or API could also take "BrooklynObject me" as a creation context and the 
+            //     receiver query the creator's catalog item id)
+            //   * propagate the catalog item id when doing setEntity, addChild
+            //   * fall back to the context entity of Tasks.current() (if set)
+            //   * when none of the above work let the user specify the catalog item
+            
             //
             // PHASE ONE
             //