You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/21 08:13:34 UTC
[GitHub] [iceberg] hameizi opened a new pull request, #6237: Core: Fix check is delete file and data file overlap
hameizi opened a new pull request, #6237:
URL: https://github.com/apache/iceberg/pull/6237
Just `deleteLower` and `deleteUpper` less than `dataLower ` is true or `deleteLower` and `deleteUpper` greater than `dataUpper` is true mean there is no overlap between the delete-file and data-file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hameizi closed pull request #6237: Core: Fix check is delete file and data file overlap
Posted by GitBox <gi...@apache.org>.
hameizi closed pull request #6237: Core: Fix check is delete file and data file overlap
URL: https://github.com/apache/iceberg/pull/6237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hameizi commented on pull request #6237: Core: Fix check is delete file and data file overlap
Posted by GitBox <gi...@apache.org>.
hameizi commented on PR #6237:
URL: https://github.com/apache/iceberg/pull/6237#issuecomment-1321652265
@rdblue can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hameizi commented on pull request #6237: Core: Fix check is delete file and data file overlap
Posted by GitBox <gi...@apache.org>.
hameizi commented on PR #6237:
URL: https://github.com/apache/iceberg/pull/6237#issuecomment-1322908600
> I think the current judgment has already dealt with this situation, IIUC, deletes and data wil **not overlap** if: `(dataLower > deleteUpper) || (deleteLower > dataUpper)` So they **will overlap** when `!((dataLower > deleteUpper) || (deleteLower > dataUpper)) ` -> `(dataLower <= deleteUpper) && (deleteLower <= dataUpper)` which is exactly the current judgment.
you are right, i will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] zhongyujiang commented on pull request #6237: Core: Fix check is delete file and data file overlap
Posted by GitBox <gi...@apache.org>.
zhongyujiang commented on PR #6237:
URL: https://github.com/apache/iceberg/pull/6237#issuecomment-1321994998
I think the current judgment has already dealt with this situation, IIUC, deletes and data wil **not overlap** if:
`(dataLower > deleteUpper) || (deleteLower > dataUpper)`
So they **will overlap** when
`!((dataLower > deleteUpper) || (deleteLower > dataUpper)) `
->
`(dataLower <= deleteUpper) && (deleteLower <= dataUpper)`
which is exactly the current judgment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org