You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/27 02:36:18 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #2413: net/tcp: correct the available iobs count if throttle is enabled
anchao opened a new pull request #2413:
URL: https://github.com/apache/incubator-nuttx/pull/2413
## Summary
net/tcp: correct the available iobs count if throttle is enabled
The number of available iobs is already sub in iob_navail(true) on line 114
```
net/tcp/tcp_recvwindow.c:
...
73 uint16_t tcp_get_recvwindow(FAR struct net_driver_s *dev)
...
114 niob_avail = iob_navail(true);
```
Change-Id: I230927904d8db08ed8d95d7fa18c5c5fce08aa5e
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
enable CONFIG_IOB_THROTTLE
## Testing
set the CONFIG_IOB_THROTTLE > 0 and check the window edge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2413: net/tcp: correct the available iobs count if throttle is enabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2413:
URL: https://github.com/apache/incubator-nuttx/pull/2413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #2413: net/tcp: correct the available iobs count if throttle is enabled
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #2413:
URL: https://github.com/apache/incubator-nuttx/pull/2413#issuecomment-734872421
@antmerlino - was there any magic here, or was it double dipping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2413: net/tcp: correct the available iobs count if throttle is enabled
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2413:
URL: https://github.com/apache/incubator-nuttx/pull/2413#issuecomment-735345853
@antmerlino seem not online. The change look reasonable, let merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org