You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/05/19 07:19:45 UTC
[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #93: feat: remove the total filed from query conditions
Fine0830 opened a new pull request, #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93
Remove the total filed from query conditions.
Video
https://user-images.githubusercontent.com/20871783/169232937-24f32361-d0d3-437b-a47e-3f2b6d3bfc0d.mov
Signed-off-by: Qiuxia Fan <qi...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#issuecomment-1131357282
Please sync to the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876705494
##########
src/views/dashboard/related/trace/TraceList.vue:
##########
@@ -83,8 +83,12 @@ const { t } = useI18n();
const traceStore = useTraceStore();
const loading = ref<boolean>(false);
const selectedKey = ref<string>("");
-const pageSize = ref<number>(15);
-const pageCount = ref<number>(5);
+const pageSize = ref<number>(20);
+const total = computed(() =>
+ traceStore.traceList.length === pageSize.value
+ ? pageSize.value * traceStore.conditions.paging.pageNum + 1
+ : pageSize.value * traceStore.conditions.paging.pageNum
+);
Review Comment:
Right... the next Icon will be disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876702586
##########
src/views/dashboard/related/trace/TraceList.vue:
##########
@@ -83,8 +83,12 @@ const { t } = useI18n();
const traceStore = useTraceStore();
const loading = ref<boolean>(false);
const selectedKey = ref<string>("");
-const pageSize = ref<number>(15);
-const pageCount = ref<number>(5);
+const pageSize = ref<number>(20);
+const total = computed(() =>
+ traceStore.traceList.length === pageSize.value
+ ? pageSize.value * traceStore.conditions.paging.pageNum + 1
+ : pageSize.value * traceStore.conditions.paging.pageNum
+);
Review Comment:
When total == current page, there would be `no next page number` to continue query, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876704594
##########
src/views/dashboard/related/trace/Filter.vue:
##########
@@ -100,8 +110,8 @@ const selectorStore = useSelectorStore();
const dashboardStore = useDashboardStore();
const traceStore = useTraceStore();
const traceId = ref<string>("");
-const minTraceDuration = ref<string>("");
-const maxTraceDuration = ref<string>("");
+const minTraceDuration = ref<number>(NaN);
+const maxTraceDuration = ref<number>(NaN);
Review Comment:
Yes. I will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876705494
##########
src/views/dashboard/related/trace/TraceList.vue:
##########
@@ -83,8 +83,12 @@ const { t } = useI18n();
const traceStore = useTraceStore();
const loading = ref<boolean>(false);
const selectedKey = ref<string>("");
-const pageSize = ref<number>(15);
-const pageCount = ref<number>(5);
+const pageSize = ref<number>(20);
+const total = computed(() =>
+ traceStore.traceList.length === pageSize.value
+ ? pageSize.value * traceStore.conditions.paging.pageNum + 1
+ : pageSize.value * traceStore.conditions.paging.pageNum
+);
Review Comment:
Right...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #93: feat: remove the total filed from query conditions
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #93:
URL: https://github.com/apache/skywalking-booster-ui/pull/93#discussion_r876701775
##########
src/views/dashboard/related/trace/Filter.vue:
##########
@@ -100,8 +110,8 @@ const selectorStore = useSelectorStore();
const dashboardStore = useDashboardStore();
const traceStore = useTraceStore();
const traceId = ref<string>("");
-const minTraceDuration = ref<string>("");
-const maxTraceDuration = ref<string>("");
+const minTraceDuration = ref<number>(NaN);
+const maxTraceDuration = ref<number>(NaN);
Review Comment:
Is this for the duration query bug fix? If so, update the change log when sync to the main repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org