You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/07 06:31:43 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
AngersZhuuuu opened a new pull request #31504:
URL: https://github.com/apache/spark/pull/31504
### What changes were proposed in this pull request?
Add show tables as Table-valued function make user convenient to analysis db information in SQL
### Why are the changes needed?
make user convenient to analysis db information in SQL
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Added UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774632171
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39563/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774640202
**[Test build #134988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134988/testReport)** for PR 31504 at commit [`3f42e91`](https://github.com/apache/spark/commit/3f42e9145b4b7452d7263d8d4ecf4646c8a51886).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774632171
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39563/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774935418
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774867116
**[Test build #134996 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134996/testReport)** for PR 31504 at commit [`3f42e91`](https://github.com/apache/spark/commit/3f42e9145b4b7452d7263d8d4ecf4646c8a51886).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774872223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774652315
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39571/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774634501
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39566/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774935398
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774640202
**[Test build #134988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134988/testReport)** for PR 31504 at commit [`3f42e91`](https://github.com/apache/spark/commit/3f42e9145b4b7452d7263d8d4ecf4646c8a51886).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774852881
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39579/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-787413463
> Do other DBMSs support this as a built-in show_columns function? If then, could you update the PR description by adding those references?
after a long time search, no other DBMS support this kind of functions. But it's really helpful for data analysis user to have a better insight for metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774639919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774647533
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39571/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774872223
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774828953
**[Test build #134996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134996/testReport)** for PR 31504 at commit [`3f42e91`](https://github.com/apache/spark/commit/3f42e9145b4b7452d7263d8d4ecf4646c8a51886).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774899751
**[Test build #135008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135008/testReport)** for PR 31504 at commit [`5e32ffd`](https://github.com/apache/spark/commit/5e32ffd3b10ed1d4e349cb0b972296ac7bd5b0fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774627288
**[Test build #134980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134980/testReport)** for PR 31504 at commit [`6d8e763`](https://github.com/apache/spark/commit/6d8e7636b7a17db3ed61530128049de10c283521).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774630305
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39563/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774626174
**[Test build #134983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134983/testReport)** for PR 31504 at commit [`4583f25`](https://github.com/apache/spark/commit/4583f251e7afd8e5ab74508fefef37b1b1a9ff26).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774935418
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774672388
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134988/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774824733
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31504:
URL: https://github.com/apache/spark/pull/31504#discussion_r571754411
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
##########
@@ -103,6 +106,46 @@ object ResolveTableValuedFunctions extends Rule[LogicalPlan] {
"numPartitions" -> IntegerType) {
case Seq(start: Long, end: Long, step: Long, numPartitions: Int) =>
Range(start, end, step, Some(numPartitions))
+ }),
+
+ "show_namespaces" -> Map(
Review comment:
Please also update https://github.com/apache/spark/blob/6786500d49efc00a658a917cb6fbf9d87090a64b/docs/sql-ref-syntax-qry-select-tvf.md#L3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-775071594
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135008/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774828953
**[Test build #134996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134996/testReport)** for PR 31504 at commit [`3f42e91`](https://github.com/apache/spark/commit/3f42e9145b4b7452d7263d8d4ecf4646c8a51886).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-775049517
**[Test build #135008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135008/testReport)** for PR 31504 at commit [`5e32ffd`](https://github.com/apache/spark/commit/5e32ffd3b10ed1d4e349cb0b972296ac7bd5b0fe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774859441
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39579/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774637563
**[Test build #134983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134983/testReport)** for PR 31504 at commit [`4583f25`](https://github.com/apache/spark/commit/4583f251e7afd8e5ab74508fefef37b1b1a9ff26).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774828090
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-857274560
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774899751
**[Test build #135008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135008/testReport)** for PR 31504 at commit [`5e32ffd`](https://github.com/apache/spark/commit/5e32ffd3b10ed1d4e349cb0b972296ac7bd5b0fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774630866
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774639919
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #31504:
URL: https://github.com/apache/spark/pull/31504#discussion_r571759051
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
##########
@@ -103,6 +106,46 @@ object ResolveTableValuedFunctions extends Rule[LogicalPlan] {
"numPartitions" -> IntegerType) {
case Seq(start: Long, end: Long, step: Long, numPartitions: Int) =>
Range(start, end, step, Some(numPartitions))
+ }),
+
+ "show_namespaces" -> Map(
+ /* show_namespaces() */
Review comment:
> This implementation will add a lot of TVFs. How about just add one TVF, something like this:
>
> ```sql
> SELECT * FROM SELECT_FROM_COMMAND('show_namespaces') WHERE identifier='a' AND pattern = 'b';
> ```
In this way its hard to fit where condition to command. and always fetch all data then filter?
If it's show tables, we can't directly filter data in metadata level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774627288
**[Test build #134980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134980/testReport)** for PR 31504 at commit [`6d8e763`](https://github.com/apache/spark/commit/6d8e7636b7a17db3ed61530128049de10c283521).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31504:
URL: https://github.com/apache/spark/pull/31504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774921702
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39591/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-775071594
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135008/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774652483
**[Test build #134980 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134980/testReport)** for PR 31504 at commit [`6d8e763`](https://github.com/apache/spark/commit/6d8e7636b7a17db3ed61530128049de10c283521).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774655892
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31504:
URL: https://github.com/apache/spark/pull/31504#discussion_r571756745
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
##########
@@ -103,6 +106,46 @@ object ResolveTableValuedFunctions extends Rule[LogicalPlan] {
"numPartitions" -> IntegerType) {
case Seq(start: Long, end: Long, step: Long, numPartitions: Int) =>
Range(start, end, step, Some(numPartitions))
+ }),
+
+ "show_namespaces" -> Map(
+ /* show_namespaces() */
Review comment:
This implementation will add a lot of TVFs. How about just add one TVF, something like this:
```sql
SELECT * FROM SELECT_FROM_COMMAND('show_namespaces') WHERE identifier='a' AND pattern = 'b';
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774655892
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774672388
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134988/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774626174
**[Test build #134983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134983/testReport)** for PR 31504 at commit [`4583f25`](https://github.com/apache/spark/commit/4583f251e7afd8e5ab74508fefef37b1b1a9ff26).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31504: [SPARK-34172][SQL] Add `SHOW DATABASES` as table-valued function
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31504:
URL: https://github.com/apache/spark/pull/31504#issuecomment-774672188
**[Test build #134988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134988/testReport)** for PR 31504 at commit [`3f42e91`](https://github.com/apache/spark/commit/3f42e9145b4b7452d7263d8d4ecf4646c8a51886).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org