[GitHub] [airflow] kaxil commented on a change in pull request #7806: Decouple DAG from DagBag and DAG from SerializedDagModel - remove cyclic imports

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #7806: Decouple DAG from DagBag and DAG from SerializedDagModel - remove cyclic imports
URL: https://github.com/apache/airflow/pull/7806#discussion_r396195341
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -455,5 +449,5 @@ def sync_to_db(self):
         """
         Save attributes about list of DAG to the DB.
         """
-        from airflow.models.dag import DAG
         DAG.bulk_sync_to_db(self.dags.values())
+        SerializedDagModel.bulk_sync_to_db(self.dags.values())
 
 Review comment:
   I am fine with `SerializedDagModel.bulk_sync_to_db` as long as you add some comments to say we don't intend to send bulk requests for serialized dags and the reason

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services