You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/19 20:41:17 UTC
[GitHub] [incubator-pekko-management] mdedetrich opened a new pull request, #69: Use pekko org in docs
mdedetrich opened a new pull request, #69:
URL: https://github.com/apache/incubator-pekko-management/pull/69
Self explanatory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich commented on a diff in pull request #69: Use pekko org in docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #69:
URL: https://github.com/apache/incubator-pekko-management/pull/69#discussion_r1199479039
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -52,7 +52,7 @@ This is a separate JAR file:
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="com.lightbend.pekko.discovery"
+ group="org.apache.pekko.pekko.discovery"
Review Comment:
Apologies, noticed comment after I merged PR. Fix is at https://github.com/apache/incubator-pekko-management/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #69: Use pekko org in docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #69:
URL: https://github.com/apache/incubator-pekko-management/pull/69#discussion_r1199477873
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -52,7 +52,7 @@ This is a separate JAR file:
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="com.lightbend.pekko.discovery"
+ group="org.apache.pekko.pekko.discovery"
Review Comment:
this should be `org.apache.pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] pjfanning commented on a diff in pull request #69: Use pekko org in docs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #69:
URL: https://github.com/apache/incubator-pekko-management/pull/69#discussion_r1199477873
##########
docs/src/main/paradox/discovery/aws.md:
##########
@@ -52,7 +52,7 @@ This is a separate JAR file:
@@dependency[sbt,Gradle,Maven] {
symbol1=PekkoManagementVersion
value1=$project.version$
- group="com.lightbend.pekko.discovery"
+ group="org.apache.pekko.pekko.discovery"
Review Comment:
this should be `org.apache.pekko` - so far, all our jars are published with groupId `org.apache.pekko`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-management] mdedetrich merged pull request #69: Use pekko org in docs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #69:
URL: https://github.com/apache/incubator-pekko-management/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org