You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Yan Fang <ya...@gmail.com> on 2014/07/20 09:36:30 UTC

Review Request 23716: SAMZA-349

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23716/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

MetricsSnapshotReporter does not refresh metrics every 60 seconds


Diffs
-----

  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala 9a56754 

Diff: https://reviews.apache.org/r/23716/diff/


Testing
-------


Thanks,

Yan Fang

Re: Review Request 23716: SAMZA-349

Posted by Yan Fang <ya...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23716/
-----------------------------------------------------------

(Updated July 22, 2014, 4:56 p.m.)


Review request for samza.


Changes
-------

updated based on Chris' comments in JIRA.

1. use getAndset in Counter.clear and Counter.set
2. use clear to get the old value and reset instead of counter.get in MetricsSnapshotReporter.


Repository: samza


Description
-------

MetricsSnapshotReporter does not refresh metrics every 60 seconds


Diffs (updated)
-----

  samza-api/src/main/java/org/apache/samza/metrics/Counter.java 6a85c66 
  samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala 9a56754 

Diff: https://reviews.apache.org/r/23716/diff/


Testing
-------


Thanks,

Yan Fang