[GitHub] [spark] MaxGekk opened a new pull request #24311: [SPARK-27401][SQL] Refactoring conversion of Date/Timestamp to/from java.sql.Date/Timestamp

[GitBox <gi...@apache.org>]

MaxGekk opened a new pull request #24311: [SPARK-27401][SQL] Refactoring conversion of Date/Timestamp to/from java.sql.Date/Timestamp
URL: https://github.com/apache/spark/pull/24311
 
 
   ## What changes were proposed in this pull request?
   
   In the PR, I propose simpler implementation of `toJavaDate()`/`fromJavaDate()` and `toJavaTimestamp()`/`fromJavaTimestamp()` by reusing existing functions of `DateTimeUtils`. This will allow to:
   - Simply implementation of `toJavaTimestamp()`, and handle properly negative inputs.
   - Avoid time zone shifting in `fromJavaDate()` and `toJavaDate()`
   - Detect `Long` overflow
   
   ## How was this patch tested?
   
   By existing test suites `DateTimeUtilsSuite`, `DateFunctionsSuite`, `DateExpressionsSuite` and `CastSuite`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org