You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kevin Clark (JIRA)" <ji...@apache.org> on 2008/10/16 21:21:44 UTC
[jira] Created: (THRIFT-175) Specs in Ruby library should be run
during make check
Specs in Ruby library should be run during make check
-----------------------------------------------------
Key: THRIFT-175
URL: https://issues.apache.org/jira/browse/THRIFT-175
Project: Thrift
Issue Type: Bug
Components: Library (Ruby)
Reporter: Kevin Clark
We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670068#action_12670068 ]
Kevin Clark commented on THRIFT-175:
------------------------------------
I agree. I'm just not sure what the right fix is. The specs are more up to date, and do more than the Test::Unit tests. It's possible we could include mspec with the tests to fix the "runs out of the box" issue. I believe it's MIT, like the rest of Rubinius and RubySpec.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-175:
-------------------------------
Attachment: 0001-THRIFT-175.-ruby-Run-specs-with-make-check.patch
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-175.-ruby-Run-specs-with-make-check.patch
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-175:
------------------------------------
Attachment: thrift-175-fix-thread-error.patch
An explicit @server.shutdown call in a few cases will get rid of the crash ([BUG] queue 0x1389310 freed with live thread(s) waiting).
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-175.-ruby-Run-specs-with-make-check.patch, thrift-175-fix-thread-error.patch
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670517#action_12670517 ]
David Reiss commented on THRIFT-175:
------------------------------------
So, the normal make check (the ones under test/rb) fail for me with
{noformat}
1) Error:
test_encodes_and_decodes_bools(BinaryProtocolAcceleratedTest):
NoMethodError: undefined method `encode_binary' for #<Thrift::BinaryProtocolAccelerated:0x403c29f0>
./core/test_binary_protocol_accelerated.rb:39:in `assert_encodes_struct'
./core/test_binary_protocol_accelerated.rb:52:in `test_encodes_and_decodes_bools'
{noformat}
running Ruby 1.8.6 on Ubuntu Hardy. Any tips? (I don't know Ruby.)
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693848#action_12693848 ]
Bryan Duxbury commented on THRIFT-175:
--------------------------------------
There's actually another problem with this. As it stands right now, the ruby specs "fail" - that is, the tests all pass, but for some reason the process ends up crashing at the end because of something related to the Nonblocking server/test that Kevin Ballard wrote. I would imagine that a nonsuccess exit code would arrest the build process.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-175:
---------------------------------
Fix Version/s: 0.1
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670523#action_12670523 ]
Kevin Clark commented on THRIFT-175:
------------------------------------
Yeah, this is testing functionality that was taken out with the thrift_native binary_protocol_accelerated reorg (THRIFT-248) and isn't your bug. They should probably just be removed, I think the reorg had new tests associated with it. Bryan?
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Michael Stockton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Stockton updated THRIFT-175:
------------------------------------
Patch Info: [Patch Available]
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-175.-ruby-Run-specs-with-make-check.patch, thrift-175-fix-thread-error.patch
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670522#action_12670522 ]
Bryan Duxbury commented on THRIFT-175:
--------------------------------------
That's happening because i got rid of those methods. I'll fix the tests.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693865#action_12693865 ]
Kevin Clark commented on THRIFT-175:
------------------------------------
If I recall, this is because of a bug in fastthread that was fixed in 1.8.6 maybe? Or a new version of fastthread?
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-175.
--------------------------------
Resolution: Fixed
Assignee: David Reiss
I have committed David's makefile patch, and I'll do mstockton's patch in a separate issue.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Assignee: David Reiss
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-175.-ruby-Run-specs-with-make-check.patch, thrift-175-fix-thread-error.patch
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670124#action_12670124 ]
Kevin Clark commented on THRIFT-175:
------------------------------------
That's doable, yup.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670062#action_12670062 ]
Bryan Duxbury commented on THRIFT-175:
--------------------------------------
Interesting. I see the complexity here. However, I don't think it makes sense to keep multiple test suites all over the place. It makes it a lot harder to comprehend the codebase for a new coder.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670059#action_12670059 ]
Kevin Clark commented on THRIFT-175:
------------------------------------
I believe the fixture data is being regenerated every time at this point, but the specs still need to be hooked up to make check.
The issue here was that the specs use rspec, which isn't in a default ruby install, so non-ruby devs wouldn't be able to run the test. The specs were intended to be for the library, while the tests (using Test::Unit) would be for the code generation.
I'm not entirely sure how this should be handled.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-175) Specs in Ruby library should be run
during make check
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670121#action_12670121 ]
David Reiss commented on THRIFT-175:
------------------------------------
It is possible to detect rspec or mspec or whatever in the configure script and only run the spec tests if it is present. This would allow anyone to successfully run "make check". The downside would be that it would silently (or quietly, if we print a "this is what you are getting" message at the end of the configure script) skip the extra tests if the dependency is absent.
> Specs in Ruby library should be run during make check
> -----------------------------------------------------
>
> Key: THRIFT-175
> URL: https://issues.apache.org/jira/browse/THRIFT-175
> Project: Thrift
> Issue Type: Bug
> Components: Library (Ruby)
> Reporter: Kevin Clark
> Fix For: 0.1
>
>
> We should also make sure that fixtures data is being regenerated _every_ time. There's a Rake task for it, but it looks like it only runs if used explicitly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.